You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/23 02:11:27 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #13257: [Improvement][api]Start the downstream workflow when it is online

zhongjiajie commented on code in PR #13257:
URL: https://github.com/apache/dolphinscheduler/pull/13257#discussion_r1055984042


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkFlowLineageMapper.xml:
##########
@@ -163,6 +163,25 @@
         AND a.task_type = 'DEPENDENT'
     </select>
 
+    <select id="queryDependentOnlineProcessDefinitionByProcessDefinitionCode" resultType="DependentProcessDefinition">

Review Comment:
   Due to the exists mapper `queryDependentProcessDefinitionByProcessDefinitionCode ` only use in one place, can you please replace it instead of add a new entrepoint named `queryDependentOnlineProcessDefinitionByProcessDefinitionCode `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org