You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/02/08 18:26:09 UTC
[GitHub] [knox] lmccay opened a new pull request #258: KNOX-2227 - Strip
Leading and Trailing Whitespace from Headers in KnoxShellTable
lmccay opened a new pull request #258: KNOX-2227 - Strip Leading and Trailing Whitespace from Headers in KnoxShellTable
URL: https://github.com/apache/knox/pull/258
## What changes were proposed in this pull request?
Currently headers are added to KnoxShellTable with any trailing or leading spaces intact. This makes any operations on the table that take a header name as a parameter difficult to use. There is no way to determine whether there are such spaces in the table even when rendered due to the padding in the cell.
I can't think of any reason that such spaces need to be retained even for CSV files when they exist in the source file.
This patch will trim the spaces so that header name based operations are more easily done and coded.
## How was this patch tested?
Added new unit test, tested manually and ran all unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] lmccay merged pull request #258: KNOX-2227 - Strip Leading
and Trailing Whitespace from Headers in KnoxShellTable
Posted by GitBox <gi...@apache.org>.
lmccay merged pull request #258: KNOX-2227 - Strip Leading and Trailing Whitespace from Headers in KnoxShellTable
URL: https://github.com/apache/knox/pull/258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services