[GitHub] [zookeeper] maoling commented on a change in pull request #1763: ZOOKEEPER-4386: Use enum to wrap the election algorithm type

[GitBox <gi...@apache.org>]

maoling commented on a change in pull request #1763:
URL: https://github.com/apache/zookeeper/pull/1763#discussion_r748695719



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
##########
@@ -1112,8 +1118,10 @@ public void initialize() throws SaslException {
             for (QuorumServer qs : getView().values()) {
                 authzHosts.add(qs.hostname);
             }
-            authServer = new SaslQuorumAuthServer(isQuorumServerSaslAuthRequired(), quorumServerLoginContext, authzHosts);
-            authLearner = new SaslQuorumAuthLearner(isQuorumLearnerSaslAuthRequired(), quorumServicePrincipal, quorumLearnerLoginContext);
+            authServer =
+                    new SaslQuorumAuthServer(isQuorumServerSaslAuthRequired(), quorumServerLoginContext, authzHosts);
+            authLearner = new SaslQuorumAuthLearner(isQuorumLearnerSaslAuthRequired(), quorumServicePrincipal,
+                    quorumLearnerLoginContext);
         } else {

Review comment:
       - `mvn checkstyle:check`  to check whether you can pass the zk's checkstyle
   - Another useless change is:
   ```
        /**
         * set zk database for this node
   +     *
         * @param database
         */
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org