[GitHub] [beam] chamini2 commented on a change in pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED

[GitBox <gi...@apache.org>]

chamini2 commented on a change in pull request #14350:
URL: https://github.com/apache/beam/pull/14350#discussion_r739559051



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##########
@@ -636,7 +636,6 @@ private static Object toBeamValue(FieldType fieldType, Object jsonBQValue) {
     if (jsonBQValue instanceof List) {
       return ((List<Object>) jsonBQValue)
           .stream()
-              .map(v -> ((Map<String, Object>) v).get("v"))
               .map(v -> toBeamValue(fieldType.getCollectionElementType(), v))

Review comment:
       Does this change account for BEAM-12863? I think we could need a way to handle it here.
   
   The ticket reporter suggested calling `toBeamRowFieldValue` instead of `toBeamValue` directly, for it to check on null array elements.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org