[GitHub] [beam] Abacn commented on a diff in pull request #27867: Add SdkHarnessOptions to DataflowPipelineOptions

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #27867:
URL: https://github.com/apache/beam/pull/27867#discussion_r1286146770


##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -232,22 +234,4 @@ public String create(PipelineOptions options) {
   boolean isHotKeyLoggingEnabled();
 
   void setHotKeyLoggingEnabled(boolean value);
-
-  /**
-   * Open modules needed for reflection that access JDK internals with Java 9+
-   *
-   * <p>With JDK 16+, <a href="#{https://openjdk.java.net/jeps/403}">JDK internals are strongly
-   * encapsulated</a> and can result in an InaccessibleObjectException being thrown if a tool or
-   * library uses reflection that access JDK internals. If you see these errors in your worker logs,
-   * you can pass in modules to open using the format module/package=target-module(,target-module)*
-   * to allow access to the library. E.g. java.base/java.lang=jamm
-   *
-   * <p>You may see warnings that jamm, a library used to more accurately size objects, is unable to
-   * make a private field accessible. To resolve the warning, open the specified module/package to
-   * jamm.
-   */
-  @Description("Open modules needed for reflection with Java 17+.")
-  List<String> getJdkAddOpenModules();
-
-  void setJdkAddOpenModules(List<String> options);

Review Comment:
   (just a note) this was added in #17110 for both SdkHarnessOptions and DataflowPipelineOptions. Because now the latter extends former, this is deduped



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org