You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/01/23 20:03:10 UTC
[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5769
Change subject: [kudu-jepsen] fixed misprints in packaged mode
......................................................................
[kudu-jepsen] fixed misprints in packaged mode
Fixed misprint in Cloudera Kudu nightly repo URL and package version
spec. Using 1.2.0 snapshots for now. Also, switched to packaged Kudu
flavor in case of running test suite tests via the 'test' target:
this is to make the code in sync with the jepsen repo where it's
targeted to run against Docker containers.
Change-Id: I409f5fae9a65124afaeac8f6535daa9bba0aed01
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
2 files changed, 6 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/5769/1
--
To view, visit http://gerrit.cloudera.org:8080/5769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I409f5fae9a65124afaeac8f6535daa9bba0aed01
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [kudu-jepsen] fixed misprints in packaged mode
......................................................................
Patch Set 1: Code-Review+1
LGTM, but can you rebase and re-test?
--
To view, visit http://gerrit.cloudera.org:8080/5769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I409f5fae9a65124afaeac8f6535daa9bba0aed01
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [kudu-jepsen] fixed misprints in packaged mode
......................................................................
Patch Set 1:
(1 comment)
also are you sure that the regular jenkins job would not be broken by the changing of the default to packages?
http://gerrit.cloudera.org:8080/#/c/5769/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj:
PS1, Line 36: 1.2.0
did you try this, there's no 1.2.0 version available in: http://repos.jenkins.cloudera.com/kudu-nightly/debian/jessie/amd64/kudu/dists/
--
To view, visit http://gerrit.cloudera.org:8080/5769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I409f5fae9a65124afaeac8f6535daa9bba0aed01
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [kudu-jepsen] fixed misprints in packaged mode
......................................................................
Patch Set 1:
(1 comment)
The regular Jenkins jobs overrides those properties -- it sets the names for nodes, etc. Overall, the Jenkins job uses clojure:run maven target which uses separate run script: $KUDU_HOME/java/kudu-jepsen/src/utils/kudu_test_runner.clj.
However, there is another issue related to the 'packaged' kudu-jepsen runs: it's not possible to fetch those packages from outside of the internal Cloudera network (i.e. you either need to run that from the internal network or have Cloudera VPN enabled). It would be nice to resolve that issue if we are about to push those changes into the Jepsen repo sometime.
http://gerrit.cloudera.org:8080/#/c/5769/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj:
PS1, Line 36: 1.2.0
> did you try this, there's no 1.2.0 version available in: http://repos.jenki
Yes, I tried that and it worked for me in Dockerized setup (jepsen repo). The actual URL is http://repos.jenkins.cloudera.com/kudu1.2.0-nightly/debian/jessie/amd64/kudu/dists/ -- it's set in line 39.
I put 1.2.0 because with 1.3.0 (or current) is that there is no regular scheme for URL and package versions: the URL does not contain the version but the 'deb' line in should have that suffix.
--
To view, visit http://gerrit.cloudera.org:8080/5769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I409f5fae9a65124afaeac8f6535daa9bba0aed01
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes