[GitHub] GabrielBrascher commented on a change in pull request #2655: Handle Ceph.

[GitBox <gi...@apache.org>]

GabrielBrascher commented on a change in pull request #2655: Handle Ceph.
URL: https://github.com/apache/cloudstack/pull/2655#discussion_r189447175
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ##########
 @@ -383,10 +383,10 @@ private String replaceStorage(String xmlDesc, Map<String, MigrateCommand.Migrate
         return getXml(doc);
     }
 
-    private String getPathFromSourceFileDevText(Set<String> paths, String sourceFileDevText) {
-        if (paths != null && sourceFileDevText != null) {
+    private String getPathFromSourceText(Set<String> paths, String sourceText) {
+        if (paths != null && sourceText != null) {
 
 Review comment:
   What do you think about `if (paths != null && !StringUtils.isBlank(sourceText))`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services