You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/10/14 16:42:37 UTC

[PR] [fix][test] Fix a resource leak in ClusterMigrationTest [pulsar]

lhotari opened a new pull request, #21366:
URL: https://github.com/apache/pulsar/pull/21366

   ### Motivation
   
   Running ClusterMigrationTest could fail with OOME.
   When investigating the problem, it showed up that ClusterMigrationTest's TestBroker inner class doesn't clean up resources properly.
   
   ### Modifications
   
   Call `super.internalCleanup()` in the `cleanup` method.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][test] Fix a resource leak in ClusterMigrationTest [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #21366:
URL: https://github.com/apache/pulsar/pull/21366#issuecomment-1763986755

   @Demogorgon314 PTAL, problem should be fixed now. I guess we should also consider moving ClusterMigrationTest to it's own test group since the test runtime duration is so long.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][test] Fix a resource leak in ClusterMigrationTest [pulsar]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #21366:
URL: https://github.com/apache/pulsar/pull/21366


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][test] Fix a resource leak in ClusterMigrationTest [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #21366:
URL: https://github.com/apache/pulsar/pull/21366#issuecomment-1763781812

   > Can you help take a look at this flaky test?
   
   @Demogorgon314 I'm investigating. It seems to fail consistently after making the change of cleaning up resources properly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][test] Fix a resource leak in ClusterMigrationTest [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #21366:
URL: https://github.com/apache/pulsar/pull/21366#issuecomment-1763989214

   @vineeth1995 @rdhabalia @vraulji567 I guess we should also consider moving ClusterMigrationTest to it's own test group since the test runtime duration is so long. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org