You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "rpuch (via GitHub)" <gi...@apache.org> on 2023/07/28 08:09:41 UTC
[GitHub] [ignite-3] rpuch opened a new pull request, #2375: IGNITE-20076 Improve networking shutdown implementation
rpuch opened a new pull request, #2375:
URL: https://github.com/apache/ignite-3/pull/2375
https://issues.apache.org/jira/browse/IGNITE-20076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2375: IGNITE-20076 Improve networking shutdown implementation
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #2375:
URL: https://github.com/apache/ignite-3/pull/2375#discussion_r1277569424
##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryServerHandshakeManager.java:
##########
@@ -177,12 +182,20 @@ public void onMessage(NetworkMessage message) {
if (message instanceof HandshakeRejectedMessage) {
HandshakeRejectedMessage msg = (HandshakeRejectedMessage) message;
- LOG.warn("Handshake rejected by client: {}", msg.reason());
+ boolean ignorable = stopping.get() || !msg.critical();
Review Comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #2375: IGNITE-20076 Improve networking shutdown implementation
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2375:
URL: https://github.com/apache/ignite-3/pull/2375#discussion_r1277566315
##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryClientHandshakeManager.java:
##########
@@ -156,12 +161,20 @@ public void onMessage(NetworkMessage message) {
if (message instanceof HandshakeRejectedMessage) {
HandshakeRejectedMessage msg = (HandshakeRejectedMessage) message;
- LOG.warn("Handshake rejected by server: {}", msg.reason());
+ boolean ignorable = stopping.get() || !msg.critical();
Review Comment:
The explanation is same :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #2375: IGNITE-20076 Improve networking shutdown implementation
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2375:
URL: https://github.com/apache/ignite-3/pull/2375#discussion_r1277565850
##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryServerHandshakeManager.java:
##########
@@ -177,12 +182,20 @@ public void onMessage(NetworkMessage message) {
if (message instanceof HandshakeRejectedMessage) {
HandshakeRejectedMessage msg = (HandshakeRejectedMessage) message;
- LOG.warn("Handshake rejected by client: {}", msg.reason());
+ boolean ignorable = stopping.get() || !msg.critical();
Review Comment:
If a node are stopping, then the situation 'I was not let by another node to do a handshake' is expected and should neither cause anything (serious) be logged nor fail the node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2375: IGNITE-20076 Improve networking shutdown implementation
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #2375:
URL: https://github.com/apache/ignite-3/pull/2375#discussion_r1277499069
##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryServerHandshakeManager.java:
##########
@@ -177,12 +182,20 @@ public void onMessage(NetworkMessage message) {
if (message instanceof HandshakeRejectedMessage) {
HandshakeRejectedMessage msg = (HandshakeRejectedMessage) message;
- LOG.warn("Handshake rejected by client: {}", msg.reason());
+ boolean ignorable = stopping.get() || !msg.critical();
Review Comment:
Why do we check the stopping flag here?
##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryClientHandshakeManager.java:
##########
@@ -156,12 +161,20 @@ public void onMessage(NetworkMessage message) {
if (message instanceof HandshakeRejectedMessage) {
HandshakeRejectedMessage msg = (HandshakeRejectedMessage) message;
- LOG.warn("Handshake rejected by server: {}", msg.reason());
+ boolean ignorable = stopping.get() || !msg.critical();
Review Comment:
Same question
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #2375: IGNITE-20076 Improve networking shutdown implementation
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov merged PR #2375:
URL: https://github.com/apache/ignite-3/pull/2375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org