You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/07 16:09:11 UTC

[GitHub] [orc] zhjwpku opened a new pull request, #1357: ORC-1347: [C++] use make_unique/make_shared when possible

zhjwpku opened a new pull request, #1357:
URL: https://github.com/apache/orc/pull/1357

   make_unique and make_shared should be prefered when creating unique_ptr and shared_ptr.
   
   a few `auto` is used in this patch to make the code shorter.
   
   Signed-off-by: Junwang Zhao <zh...@gmail.com>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1357: ORC-1347: [C++] use make_unique/make_shared when possible

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on PR #1357:
URL: https://github.com/apache/orc/pull/1357#issuecomment-1375041065

   cc @wgtmac , @stiga-huang , @williamhyun , too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1357: ORC-1347: [C++] use make_unique/make_shared when possible

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on PR #1357:
URL: https://github.com/apache/orc/pull/1357#issuecomment-1375054043

   Merged to main for Apache ORC 1.9.0. Thank you, @zhjwpku and @wgtmac .
   
   Welcome to the Apache ORC community, @zhjwpku .
   I added you to the Apache ORC contributor group and assigned ORC-1347 to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun closed pull request #1357: ORC-1347: [C++] use make_unique/make_shared when possible

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun closed pull request #1357: ORC-1347: [C++] use make_unique/make_shared when possible
URL: https://github.com/apache/orc/pull/1357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zhjwpku commented on pull request #1357: ORC-1347: [C++] use make_unique/make_shared when possible

Posted by GitBox <gi...@apache.org>.

zhjwpku commented on PR #1357:
URL: https://github.com/apache/orc/pull/1357#issuecomment-1374803860

   > All MacOS 11 CIs seem to fail. Is this tested on MacOS 11?
   
   The fail was because:
   
   /Users/runner/work/orc/orc/c++/src/Timezone.cc:452:12: error: prior to the resolution of a defect report against ISO C++11, local variable 'result' would have been copied despite being returned by name, due to its not matching the function return type ('shared_ptr<orc::FutureRule>' vs 'shared_ptr<orc::FutureRuleImpl>') [-Werror,-Wreturn-std-move-in-c++11]
       return result;
              ^~~~~~
   /Users/runner/work/orc/orc/c++/src/Timezone.cc:452:12: note: call 'std::move' explicitly to avoid copying on older compilers
       return result;
              ^~~~~~
              std::move(result)
   
   I've changed the code as recommended.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org