[jira] [Commented] (CB-10840) Use cordova-common.CordovaLogger in cordova-ios

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192922#comment-15192922 ] 

ASF GitHub Bot commented on CB-10840:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/205#discussion_r55968611
  
    --- Diff: bin/templates/scripts/cordova/Api.js ---
    @@ -202,7 +217,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) {
      */
     Api.prototype.removePlugin = function (plugin, uninstallOptions) {
         var Plugman = require('./lib/plugman/Plugman');
    -    return Plugman.get(this.locations, this.events).removePlugin(plugin, uninstallOptions);
    +    return Plugman.get(this.locations, events).removePlugin(plugin, uninstallOptions);
    --- End diff --
    
    Looks like `Plugman` doesn't use `events` parameter. Can we just remove it here and in `Plugman`?


> Use cordova-common.CordovaLogger in cordova-ios
> -----------------------------------------------
>
>                 Key: CB-10840
>                 URL: https://issues.apache.org/jira/browse/CB-10840
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org