You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/22 05:04:44 UTC

[GitHub] [flink] xuefuz commented on a change in pull request #8815: [FLINK-12918][table][hive] unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl

xuefuz commented on a change in pull request #8815: [FLINK-12918][table][hive] unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl
URL: https://github.com/apache/flink/pull/8815#discussion_r296434374
 
 

 ##########
 File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/CatalogTestUtil.java
 ##########
 @@ -40,6 +41,25 @@
  * TODO: Move util methods to CatalogTest and remove this class
  */
 public class CatalogTestUtil {
+	public static void checkEquals(CatalogTable t1, CatalogTable t2) {
 
 Review comment:
   Since CatalogTable has multiple of subclasses, we probably need to make sure that the classes are equal too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services