You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/20 10:11:29 UTC

[GitHub] [incubator-mxnet] liuzh91 opened a new pull request #17134: add batch_axis in validation handler

liuzh91 opened a new pull request #17134: add batch_axis in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17134
 
 
   ## Description ##
   add batch_axis in `ValidationHandler`
   
   fix #17104 
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] roywei merged pull request #17134: add batch_axis in validation handler

Posted by GitBox <gi...@apache.org>.
roywei merged pull request #17134: add batch_axis in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17134
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] roywei commented on issue #17134: add batch_axis in validation handler

Posted by GitBox <gi...@apache.org>.
roywei commented on issue #17134: add batch_axis in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17134#issuecomment-574903912
 
 
   @liuzh91 could you rebase your PR so CI will pass?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] liuzh91 commented on issue #17134: add batch_axis in validation handler

Posted by GitBox <gi...@apache.org>.
liuzh91 commented on issue #17134: add batch_axis in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17134#issuecomment-574976440
 
 
   > @liuzh91 could you rebase your PR so CI will pass?
   
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] liuzh91 commented on issue #17134: add batch_axis in validation handler

Posted by GitBox <gi...@apache.org>.
liuzh91 commented on issue #17134: add batch_axis in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17134#issuecomment-568148837
 
 
   > LGTM. Could you add a test?
   
   OK, I'll add a test case. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services