[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput

[GitBox <gi...@apache.org>]

eric-haibin-lin commented on a change in pull request #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r335290243
 
 

 ##########
 File path: src/kvstore/kvstore_dist.h
 ##########
 @@ -188,11 +191,19 @@ class KVStoreDist : public KVStoreLocal {
   void InitImpl(const std::vector<int>& keys,
                 const std::vector<NDArray>& values) override {
     CheckUnique(keys);
+
     for (size_t i = 0; i < keys.size(); ++i) {
       comm_->Init(keys[i], values[i].storage_type(), values[i].shape(), values[i].dtype());
+      if (slice_threshold_ > 0) {
+        // Initialize the slices as this is the only function that is assured to
+        // be called in the same order in all the worker machines
+        EncodeDefaultKey(keys[i], values[i].shape().Size(),
 
 Review comment:
   This assumes the storage type is kDefaultStorage? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services