[GitHub] [airflow] iJanki-gr opened a new issue, #29426: Mounting all volume in init/side containers breaks my setup (introduced in PR 27420)

["iJanki-gr (via GitHub)" <gi...@apache.org>]

iJanki-gr opened a new issue, #29426:
URL: https://github.com/apache/airflow/issues/29426

   ### Official Helm Chart version
   
   1.8.0 (latest released)
   
   ### Apache Airflow version
   
   2.5.1
   
   ### Kubernetes Version
   
   1.24.4
   
   ### Helm Chart configuration
   
   _No response_
   
   ### Docker Image customizations
   
   _No response_
   
   ### What happened
   
   I tried out the new 1.8.0 release of the chart. I found there is a backwards incompatible change introduced in 
   https://github.com/apache/airflow/pull/27420 that causes all extraVolumes and extraMounts to be added to all init and sidecars.
   
   This causes issues for us when using subPath mounts causing folders to be wrongly created by init containers that have nothing to do with the volume.
   
   
   
   ### What you think should happen instead
   
   Can this opinionated change be at least opt-in, guarded by some value? We would like to keep using this chart as is without forking.
   
   ### How to reproduce
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29426: Mounting all volume in init/side containers breaks my setup (introduced in PR 27420)

["boring-cyborg[bot] (via GitHub)" <gi...@apache.org>]

boring-cyborg[bot] commented on issue #29426:
URL: https://github.com/apache/airflow/issues/29426#issuecomment-1422578111

   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] iJanki-gr closed issue #29426: Mounting all volume in init/side containers breaks my setup (introduced in PR 27420)

["iJanki-gr (via GitHub)" <gi...@apache.org>]

iJanki-gr closed issue #29426: Mounting all volume in init/side containers breaks my setup (introduced in PR 27420)
URL: https://github.com/apache/airflow/issues/29426


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #29426: Mounting all volume in init/side containers breaks my setup (introduced in PR 27420)

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on issue #29426:
URL: https://github.com/apache/airflow/issues/29426#issuecomment-1422624972

   Can you please explain what is the exact problem you have and why it gets broken ? I think any decisions to change anything should be based on the assessment if this is a product problem or approach of yours that is the problem. There are good reason why volumes are mounted now (see the original PR) and adding options is often worse than opinionated decisions - maybe just you use the chart wrongly and it's better from the product point of view is you change it rather than add another option - especially that you would also need to explain consequences and maybe your case will have a variant when mounting volumes is still needed.
   
   Can you please explain the problem you have in detail


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org