[GitHub] [ozone] errose28 commented on a change in pull request #3264: HDDS-6387.[Multi-Tenant] Refactor OMMultiTenantManager and OMTenantRequestHelper

[GitBox <gi...@apache.org>]

errose28 commented on a change in pull request #3264:
URL: https://github.com/apache/ozone/pull/3264#discussion_r840973883



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -3070,13 +3068,10 @@ public TenantUserList listUsersInTenant(String tenantId, String prefix)
       return null;
     }
 
-    if (!multiTenantManager.tenantExists(tenantId)) {
-      // Throw exception to the client, which will handle this gracefully
-      throw new OMException("Tenant '" + tenantId + "' not found",
-          TENANT_NOT_FOUND);
-    }
+    OMMultiTenantManagerImpl.checkTenantExistence(

Review comment:
       I agree. I think the methods moved from OMTenantRequestHelper should be instance methods declared in the interface. All places using them should be able to get an OMMultitenantManager instance from the OzoneManager. Having static methods in OMMultitenantManagerImpl that take an OMMetadataManager doesn't really make sense because the OMMultitenantManager instance already has one as a field.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org