You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/29 03:55:59 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #14025: [broker] Fix producerFuture.completeExceptionally not called before sendErrorResponse

Jason918 opened a new pull request #14025:
URL: https://github.com/apache/pulsar/pull/14025


   
   
   ### Motivation
   
   
   `producerFuture.completeExceptionally` is not called before `sendErrorResponse` when encryption check or schema check failed in `ServerCnx.handleProduce`.
   
   ### Modifications
   
   Add `producerFuture.completeExceptionally` before `sendErrorResponse`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests.
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc` 
   
   bug fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 closed pull request #14025: [broker] Fix producerFuture.completeExceptionally not called before sendErrorResponse

Posted by GitBox <gi...@apache.org>.
Jason918 closed pull request #14025:
URL: https://github.com/apache/pulsar/pull/14025


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14025: [broker] Fix producerFuture.completeExceptionally not called before sendErrorResponse

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14025:
URL: https://github.com/apache/pulsar/pull/14025


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org