[GitHub] [spark] jackylee-ch commented on a change in pull request #35815: [SPARK-38521][SQL] Throw Exception if overwriting hive partition table with dynamic and staticPartitionOverwriteMode

[GitBox <gi...@apache.org>]

jackylee-ch commented on a change in pull request #35815:
URL: https://github.com/apache/spark/pull/35815#discussion_r824459802



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
##########
@@ -234,7 +237,7 @@ case class InsertIntoHadoopFsRelationCommand(
     if (fs.exists(staticPrefixPath) && !committer.deleteWithJob(fs, staticPrefixPath, true)) {
       throw QueryExecutionErrors.cannotClearOutputDirectoryError(staticPrefixPath)
     }
-    // now clear all custom partition locations (e.g. /custom/dir/where/foo=2/bar=4)
+    // now clear custom static partition locations (e.g. /custom/dir/where/foo=1)

Review comment:
       This is changed because after this PR, only overwriting the static partition will run into deleteMatchingPartitions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org