You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/29 08:55:00 UTC

[GitHub] [spark] panbingkun opened a new pull request, #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

panbingkun opened a new pull request, #41364:
URL: https://github.com/apache/spark/pull/41364

   ### What changes were proposed in this pull request?
   The pr aims to follow up PR: https://github.com/apache/spark/pull/41341
   
   ### Why are the changes needed?
   Fix issue which caused by inconsistent versions of `bytebuddy` that `selenium` and `mockito-core` rely on.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   - Manual testing:
   (base) panbingkun:~/Developer/spark/spark-community$build/sbt "connect/test"
   ...
   [info] - function_raise_error (2 milliseconds)
   [info] - column_when_otherwise (4 milliseconds)
   [info] - function_date_trunc (4 milliseconds)
   [info] Run completed in 21 seconds, 249 milliseconds.
   [info] Total number of tests run: 576
   [info] Suites: completed 12, aborted 0
   [info] Tests: succeeded 576, failed 0, canceled 0, ignored 0, pending 0
   [info] All tests passed.
   [success] Total time: 77 s (01:17), completed May 29, 2023 4:45:57 PM
   
   - Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569433212

   > I'm checking the AS-IS master branch. Unfortunately, it seems that I found another instance of `mockito`-`bytebuddy` conflicts in YARN module.
   > 
   > ```
   > $ git log --oneline -n1
   > 8a1100806d (HEAD -> master, apache/master, apache/HEAD) [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version
   > 
   > $ build/sbt -Pyarn "yarn/testOnly *.YarnShuffleServiceMetricsSuite"
   > ...
   > [info] YarnShuffleServiceMetricsSuite:
   > [info] org.apache.spark.network.yarn.YarnShuffleServiceMetricsSuite *** ABORTED *** (25 milliseconds)
   > [info]   java.lang.IllegalStateException: Could not initialize plugin: interface org.mockito.plugins.MockMaker (alternate: null)
   > ```
   > 
   > Could you double-check the above, @panbingkun ?
   
   Let me check it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on a diff in pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #41364:
URL: https://github.com/apache/spark/pull/41364#discussion_r1209496830


##########
pom.xml:
##########
@@ -1113,6 +1125,16 @@
         <groupId>org.scalatestplus</groupId>
         <artifactId>mockito-4-11_${scala.binary.version}</artifactId>
         <version>3.2.16.0</version>
+        <exclusions>

Review Comment:
   Yeah it feels like one or the other of these changes is needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569452018

   I think this issue still exists in the `SBT` compilation, so I will continue to investigate it, finding a better solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569379919

   I'm checking the AS-IS master branch. Unfortunately, it seems that I found another instance of `mockito`-`bytebuddy` conflicts in YARN module.
   
   ```
   $ git log --oneline -n1
   8a1100806d (HEAD -> master, apache/master, apache/HEAD) [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version
   
   $ build/sbt -Pyarn "yarn/testOnly *.YarnShuffleServiceMetricsSuite"
   ...
   [info] YarnShuffleServiceMetricsSuite:
   [info] org.apache.spark.network.yarn.YarnShuffleServiceMetricsSuite *** ABORTED *** (25 milliseconds)
   [info]   java.lang.IllegalStateException: Could not initialize plugin: interface org.mockito.plugins.MockMaker (alternate: null)
   ```
   
   Could you double-check the above, @panbingkun ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1568493117

   This is what happens when you set the new version in dependencyManagement, but don't exclude? hm. I'm thinking it's simpler to go back to your first version if so


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1567693863

   Wait, do we need a direct dependency? I thought perhaps just managing the dependency would have the desired effect without exclusion. I didn't realize this alternative would change so much. We don't actually directly use this dependnecy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1568467948

   1.When I do not exclude it, and do not depend on it directly, result as follows:
   <img width="427" alt="image" src="https://github.com/apache/spark/assets/15246973/b22c5527-f830-4e3a-b110-5355d21b1760">
   
   2.When I exclude it, and do not depend on it directly, result as follows:
   ![image](https://github.com/apache/spark/assets/15246973/7723c90e-5456-4d68-b9c2-3f818f8d7475)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569433237

   I think this should be a classpath related issue and only affect the sbt. 
   
   May be we should revert this one(I think using `byte-buddy` 1.12.19 and `byte-buddy-agent` 1.12.19 should also be ok) and solve the problem by exlcude `byte-buddy` 1.14.4 in SparkBuild.scala?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569336697

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on a diff in pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41364:
URL: https://github.com/apache/spark/pull/41364#discussion_r1209473098


##########
pom.xml:
##########
@@ -1113,6 +1125,16 @@
         <groupId>org.scalatestplus</groupId>
         <artifactId>mockito-4-11_${scala.binary.version}</artifactId>
         <version>3.2.16.0</version>
+        <exclusions>

Review Comment:
   I think it's unnecessary, but I think we should copy 
   ```
   <dependency>
         <groupId>net.bytebuddy</groupId>
         <artifactId>byte-buddy</artifactId>
         <scope>test</scope>
       </dependency>
       <dependency>
         <groupId>net.bytebuddy</groupId>
         <artifactId>byte-buddy-agent</artifactId>
         <scope>test</scope>
       </dependency>
   ```
    to the module using `mockito-core` because there is just configuring `dependencyManagement` instead of `dependencies` 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569441760

   Oh, let me try in a docker again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on a diff in pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #41364:
URL: https://github.com/apache/spark/pull/41364#discussion_r1209449959


##########
pom.xml:
##########
@@ -1113,6 +1125,16 @@
         <groupId>org.scalatestplus</groupId>
         <artifactId>mockito-4-11_${scala.binary.version}</artifactId>
         <version>3.2.16.0</version>
+        <exclusions>

Review Comment:
   Are these exclusions needed, if we're manually managing the dependency version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on a diff in pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41364:
URL: https://github.com/apache/spark/pull/41364#discussion_r1209647578


##########
pom.xml:
##########
@@ -1113,6 +1125,16 @@
         <groupId>org.scalatestplus</groupId>
         <artifactId>mockito-4-11_${scala.binary.version}</artifactId>
         <version>3.2.16.0</version>
+        <exclusions>

Review Comment:
   This is done. @srowen @LuciferYang 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1568424174

   It appears nowhere in the build, when you do not exclude it, and do not depend on it directly? that seems strange, if it's needed by a third party lib. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569448994

   Thank you for confirming! I also verified that it succeeds cleanly on docker Java images. Sorry for the false alarm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version
URL: https://github.com/apache/spark/pull/41364


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1567708189

   eg, When we did not add 
   <img width="351" alt="image" src="https://github.com/apache/spark/assets/15246973/452b2ade-e6c1-4b0f-8c66-cf2c140e291a">
   to `resource-managers/yarn/pom.xml`
   I run `./build/mvn -pl :spark-yarn_2.13 -Phadoop-3 -Phive-2.3 -Pyarn -Phive-thriftserver -Phive dependency:tree`
   result as follows:
   <img width="513" alt="image" src="https://github.com/apache/spark/assets/15246973/a612bad7-3147-4bfa-922e-0ce61b7b6915">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1568543013

   When I only add
   <img width="369" alt="image" src="https://github.com/apache/spark/assets/15246973/68937c86-4265-43ac-9562-dbde6bdac5e7">
   
   And don't exclude anything, result as follows:
   <img width="523" alt="image" src="https://github.com/apache/spark/assets/15246973/74e95ab6-7518-43ad-a5b2-46388d20f2db">
   
   It seems to be what we want, and it's very slight.
   Let's do it this way!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569435661

   But my local env is ok
   <img width="1016" alt="image" src="https://github.com/apache/spark/assets/15246973/ffa06460-4edf-4f4d-a46e-e13a87393f93">
   
   Can you reproduce it? @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569449474

   ```
   $ docker run -it --rm -v $PWD:/spark -w /spark --entrypoint /bin/bash openjdk:17
   bash-4.4# build/sbt -Pyarn "yarn/testOnly *.YarnShuffleServiceMetricsSuite"
   Using /usr/java/openjdk-17 as default JAVA_HOME.
   Note, this will be overridden by -java-home if it is set.
   Attempting to fetch sbt
   Launching sbt from build/sbt-launch-1.8.3.jar
   [info] [launcher] getting org.scala-sbt sbt 1.8.3  (this may take some time)...
   [info] [launcher] getting Scala 2.12.17 (for sbt)...
   [info] welcome to sbt 1.8.3 (Oracle Corporation Java 17.0.2)
   ...
   [info] YarnShuffleServiceMetricsSuite:
   [info] - metrics named as expected (161 milliseconds)
   [info] - openBlockRequestLatencyMillis - collector receives correct types (83 milliseconds)
   [info] - registerExecutorRequestLatencyMillis - collector receives correct types (3 milliseconds)
   [info] - blockTransferRateBytes - collector receives correct types (3 milliseconds)
   [info] - blockTransferRate - collector receives correct types (3 milliseconds)
   [info] - blockTransferMessageRate - collector receives correct types (2 milliseconds)
   [info] - registeredExecutorsSize - collector receives correct types (42 milliseconds)
   [info] Run completed in 8 seconds, 699 milliseconds.
   [info] Total number of tests run: 7
   [info] Suites: completed 1, aborted 0
   [info] Tests: succeeded 7, failed 0, canceled 0, ignored 0, pending 0
   [info] All tests passed.
   [success] Total time: 232 s (03:52), completed May 31, 2023, 3:38:45 AM
   bash-4.4#
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #41364: [SPARK-43830][BUILD][FOLLOWUP] Update scalatest and scalatestplus related dependencies to newest version

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41364:
URL: https://github.com/apache/spark/pull/41364#issuecomment-1569450553

   > But my local env is ok <img alt="image" width="1131" src="https://user-images.githubusercontent.com/15246973/242149465-3cf0e2a0-09bd-493a-b733-b9b2040e166b.png">
   > 
   > Can you reproduce it? @LuciferYang
   
   No, It ran successfully in my testing environment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org