[jira] [Resolved] (CB-7947) pauseTimers() called too aggressively on Android

["Andrew Grieve (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CB-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Grieve resolved CB-7947.
-------------------------------
    Resolution: Fixed

Fixed in 4.0.0-dev

Deleted the code to pauseTimers() for startActivityForResult().

Thinking now that pauseTimers() affecting all webview instances may not actually be an issue, since when moving between activities with CordovaWebViews, you'd have onPause(), followed by onResume() of the new one, and so things will be paused and resumed no problem. Plus - keepRunning is true by default.

> pauseTimers() called too aggressively on Android
> ------------------------------------------------
>
>                 Key: CB-7947
>                 URL: https://issues.apache.org/jira/browse/CB-7947
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>
> ML discussion: http://markmail.org/thread/dhs7lnnrhq6z24vb
> Couple of issues:
> 1. pauseTimers(), although an instance method, actually applies to all webviews
> 2. pauseTimers() is always being called during startActivityForResult(), even though there's no reason to do this.
> Proposed changes:
> - Pause timers during a startActivityForResult only when KeepRunning preference is false (this should happen anyways, since the activity's onPause is fired in this case)
> - 4.0.x branch: Create a setGloballyPauseTimers(boolean) on CordovaWebview interface in 4.0.x that is documented to have the same semantics as WebView.pause/resume timers. 
> - 4.0.x branch: Move the pausing & resuming into CordovaActivity, rather than passing it as a boolean to the onPause() function



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org