You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2002/01/08 22:07:33 UTC

Re: svn commit: rev 762 - trunk/subversion/include trunk/subversion/libsvn_subr

cmpilato@tigris.org wrote:

>Author: cmpilato
>Date: 2002-01-08 20:18 GMT
>New Revision: 762
>
>Modified:
>   trunk/subversion/include/svn_io.h
>   trunk/subversion/libsvn_subr/io.c
>
[snip]

>
>-         - EOL strings can be multi-character.  This means we run the
>-           risk of an EOL string spanning chunks read from SRC
>+        case '$':
>+          /* If we are currently in the middle of tracking a possible
>+             keyword expansion, then this is its terminator.  Else,
>+             this is the beginning of a new possible keyword. */
>+        default:
>
MSVC complains about a missing semicolon here.

>
>+        }
> 
>-         - Perhaps we need a function to simply figure out what SRC's
>-           current EOL string is, heuristically, since it might have
>-           been tainted by an unaware tool?  
>+      /* ### TODO:  Here's the real meat.  Things to keep in mind:
> 
>


-- 
Brane �ibej   <br...@xbc.nu>   http://www.xbc.nu/brane/




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 762 - trunk/subversion/include trunk/subversion/libsvn_subr

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Branko Čibej <br...@xbc.nu> writes:
> Ah ... actually, the semicolon is in the wrong place. Allow me ...

?  Wow, today is full of surprises... I'll wait for your commit.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 762 - trunk/subversion/include trunk/subversion/libsvn_subr

Posted by Branko Čibej <br...@xbc.nu>.
Karl Fogel wrote:

>Branko �ibej <br...@xbc.nu> writes:
>
>>>-         - EOL strings can be multi-character.  This means we run the
>>>-           risk of an EOL string spanning chunks read from SRC
>>>+        case '$':
>>>+          /* If we are currently in the middle of tracking a possible
>>>+             keyword expansion, then this is its terminator.  Else,
>>>+             this is the beginning of a new possible keyword. */
>>>+        default:
>>>
>>MSVC complains about a missing semicolon here.
>>
>
>Fixed.
>
Ah ... actually, the semicolon is in the wrong place. Allow me ...



-- 
Brane �ibej   <br...@xbc.nu>   http://www.xbc.nu/brane/




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 762 - trunk/subversion/include trunk/subversion/libsvn_subr

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Branko Čibej <br...@xbc.nu> writes:
> >-         - EOL strings can be multi-character.  This means we run the
> >-           risk of an EOL string spanning chunks read from SRC
> >+        case '$':
> >+          /* If we are currently in the middle of tracking a possible
> >+             keyword expansion, then this is its terminator.  Else,
> >+             this is the beginning of a new possible keyword. */
> >+        default:
> >
> MSVC complains about a missing semicolon here.

Fixed.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org