You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2010/08/16 12:08:26 UTC
DO NOT REPLY [Bug 49752] New: [PATCH] findbugs build target
enhancements
https://issues.apache.org/bugzilla/show_bug.cgi?id=49752
Summary: [PATCH] findbugs build target enhancements
Product: Fop
Version: 1.1dev
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: glenn@skynav.com
This patch enhances the findbugs build target as follows:
* changes from using external findbugs.jar location, ${findbugs.home.dir}, to
use a copy/link of findbugs.jar in lib/build; this makes findbugs usage
consistent with checkstyle usage, which is also copied/linked into lib/build
rather than referenced from an external directory;
* adds libs-build-classpath, ant.jar, and ant-launcher.jar to auxiliary class
path in order to eliminate "missing class" warnings which prevent findbugs from
testing a full transitive closure (of dependent classes);
* adds (empty) findbugs-exclude.xml file in order to filter blessed warnings
(in future cleanup work);
* adds new targets findbugs-xml and findbugs-html in order to separately
generate the XML and HTML output formats, and rewrites the existing findbugs
target to be an alias for findbugs-html;
This patch is applied against revision 985949.
Regards,
Glenn
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49752] [PATCH] findbugs build target enhancements
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49752
--- Comment #1 from Glenn Adams <gl...@skynav.com> 2010-08-16 06:09:45 EDT ---
Created an attachment (id=25890)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25890)
Patch is applied against revision 985949.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49752] [PATCH] findbugs build target enhancements
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49752
Simon Pepping <sp...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Simon Pepping <sp...@apache.org> 2010-08-18 06:13:11 EDT ---
Patch applied: http://svn.apache.org/viewvc?view=revision&revision=986616
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49752] [PATCH] findbugs build target enhancements
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49752
--- Comment #4 from Glenn Adams <gl...@skynav.com> 2010-08-17 03:10:17 EDT ---
I just replaced the patch file, restoring the prior usage of findbugs.home.dir
in build.local.properties. I believe this resolves the problem you encountered.
G.
(In reply to comment #2)
> Glenn, I tried to apply this, but I run into many
> java.lang.NoClassDefFoundError exceptions. The findbugs comes with a library
> full of jar files. It seems that many if not all are required in the lib/build
> dir. They could all be copied into that directory, or into a separate directory
> findbugs. The latter option might introduce duplicate jar files, but would also
> protect against the requirement of different versions of the same jar file by
> different tools. It brings us basically back to the findbugs.home.dir
> situation, perhaps with a default value = lib/findbugs.
>
> Also, change <findbugs home="${findbugs.home.dir}" to <findbugs
> home="${lib-tools}", or leave it if you go back to that variable.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49752] [PATCH] findbugs build target enhancements
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49752
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25890|0 |1
is obsolete| |
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49752] [PATCH] findbugs build target enhancements
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49752
--- Comment #2 from Simon Pepping <sp...@apache.org> 2010-08-16 07:51:36 EDT ---
Glenn, I tried to apply this, but I run into many
java.lang.NoClassDefFoundError exceptions. The findbugs comes with a library
full of jar files. It seems that many if not all are required in the lib/build
dir. They could all be copied into that directory, or into a separate directory
findbugs. The latter option might introduce duplicate jar files, but would also
protect against the requirement of different versions of the same jar file by
different tools. It brings us basically back to the findbugs.home.dir
situation, perhaps with a default value = lib/findbugs.
Also, change <findbugs home="${findbugs.home.dir}" to <findbugs
home="${lib-tools}", or leave it if you go back to that variable.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49752] [PATCH] findbugs build target enhancements
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49752
--- Comment #3 from Glenn Adams <gl...@skynav.com> 2010-08-17 03:06:56 EDT ---
Created an attachment (id=25895)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25895)
Patch applied to revision 986204.
Back out change to use lib/build directory for findbugs.jar. Restore previous
usage of setting findbugs.home.dir in build-local.properties to top level
directory of findbugs binary distribution.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49752] [PATCH] findbugs build target enhancements
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49752
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.