You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/27 07:38:51 UTC

[GitHub] [shardingsphere] TeslaCN opened a new issue #12770: Consider renaming ConfigurationPropertyKey#EXECUTOR_SIZE

TeslaCN opened a new issue #12770:
URL: https://github.com/apache/shardingsphere/issues/12770


   ## Discussion
   
   The `executor-size` is too simple to understand in `server.yaml`, consider renaming it.
   
   https://github.com/apache/shardingsphere/blob/64cfdc01e964e45b1711ddca57c06ea2979b7e0a/shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/server.yaml#L60
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #12770: Consider renaming ConfigurationPropertyKey#EXECUTOR_SIZE

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #12770:
URL: https://github.com/apache/shardingsphere/issues/12770#issuecomment-930775138


   +1 for `kernel-executor-size`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero closed issue #12770: Consider renaming ConfigurationPropertyKey#EXECUTOR_SIZE

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #12770:
URL: https://github.com/apache/shardingsphere/issues/12770


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on issue #12770: Consider renaming ConfigurationPropertyKey#EXECUTOR_SIZE

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #12770:
URL: https://github.com/apache/shardingsphere/issues/12770#issuecomment-930704839


   Since this property is used in `org.apache.shardingsphere.infra.executor.kernel.ExecutorEngine` and referenced by the following classes:
   * `org.apache.shardingsphere.mode.metadata.MetaDataContextsBuilder`
   * `org.apache.shardingsphere.proxy.backend.context.BackendExecutorContext`
   
   I've come out with some names: 
   * `kernel-executor-size`
   * `infra-executor-size`
   * `executor-engine-thread-pool-size`
   * `sql-executor-size`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org