You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/02/08 15:01:28 UTC
[jira] Created: (WICKET-2728) Location headers (redirects) should
be absolute, not relative URLs
Location headers (redirects) should be absolute, not relative URLs
------------------------------------------------------------------
Key: WICKET-2728
URL: https://issues.apache.org/jira/browse/WICKET-2728
Project: Wicket
Issue Type: Bug
Components: wicket
Reporter: Sebb
See WICKET-2600. I think the fix is wrong.
Location URLs are supposed to be absolute:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2728) Location headers (redirects) should
be absolute, not relative URLs
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2728:
----------------------------------
Fix Version/s: 1.5-M2
(was: 1.5-M1)
> Location headers (redirects) should be absolute, not relative URLs
> ------------------------------------------------------------------
>
> Key: WICKET-2728
> URL: https://issues.apache.org/jira/browse/WICKET-2728
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Sebb
> Fix For: 1.5-M2
>
>
> See WICKET-2600. I think the fix is wrong.
> Location URLs are supposed to be absolute:
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2728) Location headers (redirects) should
be absolute, not relative URLs
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898615#action_12898615 ]
Martin Grigorov commented on WICKET-2728:
-----------------------------------------
Just for the record: we set "Location" header in org.apache.wicket.request.http.handler.RedirectRequestHandler.respond(IRequestCycle).
If the user application really wants absolute URL then it will need to override this class/method
> Location headers (redirects) should be absolute, not relative URLs
> ------------------------------------------------------------------
>
> Key: WICKET-2728
> URL: https://issues.apache.org/jira/browse/WICKET-2728
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Sebb
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
>
> See WICKET-2600. I think the fix is wrong.
> Location URLs are supposed to be absolute:
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2728) Location headers (redirects) should
be absolute, not relative URLs
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2728:
----------------------------------
Fix Version/s: 1.5-M1
unfortunately in reality it is not so simple. many people run their webapps behind proxies with url rewriting. this is the main reason why wicket tries to use relative urls for everything. we cannot construct an absolute url manually without the user's help because we do not know the proxy/url rewriting scheme they use. that said, while the spec says that only absolute urls should be used all browsers seem to understand relative urls, specs are written against the perfect world, apps are built against the real one.
i suppose we can intoduce a method into request to allow users a chance to rewrite a relative url into an absolute during a redirect. assigning this to 1.5
also note that wicket-2600 did not change wicket to use absolute to relative, wicket never used absolute urls for redirects unless you consider the "./" syntax as absolute....
> Location headers (redirects) should be absolute, not relative URLs
> ------------------------------------------------------------------
>
> Key: WICKET-2728
> URL: https://issues.apache.org/jira/browse/WICKET-2728
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Sebb
> Fix For: 1.5-M1
>
>
> See WICKET-2600. I think the fix is wrong.
> Location URLs are supposed to be absolute:
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2728) Location headers (redirects) should
be absolute, not relative URLs
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2728.
-----------------------------------
Assignee: Igor Vaynberg
Resolution: Won't Fix
according to the servlet spec it is the container's job to rewrite relative redirects to absolute. i dont think we set location headers anywhere manually.
> Location headers (redirects) should be absolute, not relative URLs
> ------------------------------------------------------------------
>
> Key: WICKET-2728
> URL: https://issues.apache.org/jira/browse/WICKET-2728
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Sebb
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
>
> See WICKET-2600. I think the fix is wrong.
> Location URLs are supposed to be absolute:
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2728) Location headers (redirects) should
be absolute, not relative URLs
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898627#action_12898627 ]
Igor Vaynberg commented on WICKET-2728:
---------------------------------------
only for 301s, and wicket is not creating that url, the user is.
> Location headers (redirects) should be absolute, not relative URLs
> ------------------------------------------------------------------
>
> Key: WICKET-2728
> URL: https://issues.apache.org/jira/browse/WICKET-2728
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Sebb
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
>
> See WICKET-2600. I think the fix is wrong.
> Location URLs are supposed to be absolute:
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.