You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2017/06/30 00:10:00 UTC

[2/3] beam git commit: Don't call .testingPipelineOptions() a second time

Don't call .testingPipelineOptions() a second time


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/ab7f6f6d
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/ab7f6f6d
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/ab7f6f6d

Branch: refs/heads/master
Commit: ab7f6f6dbd3ad67c5da577bc9395cb09e35069d9
Parents: 0acfe70
Author: Stephen Sisk <si...@google.com>
Authored: Thu Jun 29 13:29:22 2017 -0700
Committer: Stephen Sisk <si...@google.com>
Committed: Thu Jun 29 13:29:22 2017 -0700

----------------------------------------------------------------------
 .../java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java   | 2 +-
 .../java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java  | 2 +-
 .../java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java     | 2 +-
 .../java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteIT.java    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/ab7f6f6d/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java
index e47fd0f..91f0bae 100644
--- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java
+++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java
@@ -42,7 +42,7 @@ public class BigtableReadIT {
     BigtableTestOptions options = TestPipeline.testingPipelineOptions()
         .as(BigtableTestOptions.class);
 
-    String project = TestPipeline.testingPipelineOptions().as(GcpOptions.class).getProject();
+    String project = options.as(GcpOptions.class).getProject();
 
     BigtableOptions.Builder bigtableOptionsBuilder = new BigtableOptions.Builder()
         .setProjectId(project)

http://git-wip-us.apache.org/repos/asf/beam/blob/ab7f6f6d/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java
index 72ba836..010bcc4 100644
--- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java
+++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java
@@ -79,7 +79,7 @@ public class BigtableWriteIT implements Serializable {
   public void setup() throws Exception {
     PipelineOptionsFactory.register(BigtableTestOptions.class);
     options = TestPipeline.testingPipelineOptions().as(BigtableTestOptions.class);
-    project = TestPipeline.testingPipelineOptions().as(GcpOptions.class).getProject();
+    project = options.as(GcpOptions.class).getProject();
 
     bigtableOptions =
         new Builder()

http://git-wip-us.apache.org/repos/asf/beam/blob/ab7f6f6d/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
index 32183f9..bfbda50 100644
--- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
+++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
@@ -88,7 +88,7 @@ public class SpannerReadIT {
     PipelineOptionsFactory.register(SpannerTestPipelineOptions.class);
     options = TestPipeline.testingPipelineOptions().as(SpannerTestPipelineOptions.class);
 
-    project = TestPipeline.testingPipelineOptions().as(GcpOptions.class).getProject();
+    project = options.as(GcpOptions.class).getProject();
 
     spanner = SpannerOptions.newBuilder().setProjectId(project).build().getService();
 

http://git-wip-us.apache.org/repos/asf/beam/blob/ab7f6f6d/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteIT.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteIT.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteIT.java
index 78a360f..436d01e 100644
--- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteIT.java
+++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteIT.java
@@ -87,7 +87,7 @@ public class SpannerWriteIT {
     PipelineOptionsFactory.register(SpannerTestPipelineOptions.class);
     options = TestPipeline.testingPipelineOptions().as(SpannerTestPipelineOptions.class);
 
-    project = TestPipeline.testingPipelineOptions().as(GcpOptions.class).getProject();
+    project = options.as(GcpOptions.class).getProject();
 
     spanner = SpannerOptions.newBuilder().setProjectId(project).build().getService();