[GitHub] [helix] jiajunwang commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r336606207
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/monitoring/metrics/model/Metric.java
 ##########
 @@ -31,11 +31,6 @@
    */
   String getMetricName();
 
-  /**
-   * Resets the internal state of this metric.
-   */
-  void reset();
 
 Review comment:
   As we discussed offline, we will remove this method for now.
   1. the reset is not used for now.
   2. the current implementation of reset in the latency metric is not doing the expected resetting logic. So we should change it to a private method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org