You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sian January (JIRA)" <ji...@apache.org> on 2008/07/09 17:45:33 UTC

[jira] Commented: (HARMONY-5902) [classlib][pack200] ClassConstantPool overuses ArrayLists

    [ https://issues.apache.org/jira/browse/HARMONY-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612158#action_12612158 ] 

Sian January commented on HARMONY-5902:
---------------------------------------

Thanks Aleksey - your patch worked for me too so I checked it in at r675234.

Andrew - in the original patch did you change from using Iterator to ArrayList.get because it's faster, or for a different reason?

> [classlib][pack200] ClassConstantPool overuses ArrayLists
> ---------------------------------------------------------
>
>                 Key: HARMONY-5902
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5902
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M6
>         Environment: Pack200 HEAD
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>            Priority: Minor
>             Fix For: 5.0M7
>
>         Attachments: main.patch, pack200-addnested-v1.patch
>
>
> The class ClassConstantPool uses ArrayList in places where it should use arrays. This patch fixes one of the most egregious offenders.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.