You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/31 10:29:16 UTC
[GitHub] [doris] morningman opened a new pull request, #13830: [meta](recover) change dropInfo and RecoverInfo to GSON
morningman opened a new pull request, #13830:
URL: https://github.com/apache/doris/pull/13830
# Proposed changes
Issue Number: close #xxx
## Problem summary
Follow up #13067
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on a diff in pull request #13830: [meta](recover) change dropInfo and RecoverInfo to GSON
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on code in PR #13830:
URL: https://github.com/apache/doris/pull/13830#discussion_r1009282789
##########
fe/fe-core/src/main/java/org/apache/doris/journal/JournalEntity.java:
##########
@@ -196,9 +196,7 @@ public void readFields(DataInput in) throws IOException {
break;
}
case OperationType.OP_DROP_TABLE: {
- data = new DropInfo();
- ((DropInfo) data).readFields(in);
- isRead = true;
+ data = DropInfo.read(in);
Review Comment:
```suggestion
data = DropInfo.read(in);
isRead = true;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on a diff in pull request #13830: [meta](recover) change dropInfo and RecoverInfo to GSON
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on code in PR #13830:
URL: https://github.com/apache/doris/pull/13830#discussion_r1009282988
##########
fe/fe-core/src/main/java/org/apache/doris/journal/JournalEntity.java:
##########
@@ -238,14 +236,11 @@ public void readFields(DataInput in) throws IOException {
case OperationType.OP_RECOVER_DB:
case OperationType.OP_RECOVER_TABLE:
case OperationType.OP_RECOVER_PARTITION: {
- data = new RecoverInfo();
- ((RecoverInfo) data).readFields(in);
- isRead = true;
+ data = RecoverInfo.read(in);
Review Comment:
```suggestion
data = RecoverInfo.read(in);
isRead = true;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13830: [meta](recover) change dropInfo and RecoverInfo to GSON
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13830:
URL: https://github.com/apache/doris/pull/13830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13830: [meta](recover) change dropInfo and RecoverInfo to GSON
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13830:
URL: https://github.com/apache/doris/pull/13830#issuecomment-1297306707
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.35 seconds
load time: 567 seconds
storage size: 17154655343 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221031155621_clickbench_pr_36577.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13830: [meta](recover) change dropInfo and RecoverInfo to GSON
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13830:
URL: https://github.com/apache/doris/pull/13830#issuecomment-1296893357
cc @nextdreamblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org