You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Benjamin Bentmann <be...@udo.edu> on 2009/08/22 17:44:28 UTC
Re: [plexus-dev] [jira] Created: (PLXUTILS-117) The classes from
org.codehaus.plexus.utils.interpolation are not self-contained
> The classes from org.codehaus.plexus.utils.interpolation are not self-contained
> -------------------------------------------------------------------------------
>
> Key: PLXUTILS-117
> URL: http://jira.codehaus.org/browse/PLXUTILS-117
> Project: Plexus Utils
> Issue Type: Bug
> Affects Versions: 1.5.15
> Reporter: Benjamin Bentmann
> Attachments: pu-vs-pi.zip
>
> [r8255|http://fisheye.codehaus.org/changelog/plexus/?cs=8255] caused exclusion of the plexus-interpolation classes from the plexus-utils JAR. This in turn makes usage of the {{org.codehaus.plexus.utils.intepolation.*}} classes from a standalone plexus-utils JAR impossible as their super classes can't be resolved. See the attached demo project that fails upon "mvn clean compile".
>
> Note sure whether the change in the above commit was actually necessary given that previous plexus-utils versions like 1.5.12 apparently shipped with a [dependency reduced POM|http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.5.12/plexus-utils-1.5.12.pom] that already declared plexus-interpolation as provided.
>
> Declaring plexus-interpolation as provided in the original POM causes the dependency to be ignored by the Shade Plugin because that uses {{@requiresDependencyResolution runtime}} but provided dependencies are not resolved for this resolution scope...
>
How about if we just remove the org.codehaus.plexus.utils.intepolation
package from plexus-utils, bump the version number for plexus-utils to
1.6 and get back to a simple project that doesn't need fancy shading?
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [plexus-dev] [jira] Created: (PLXUTILS-117) The classes from
org.codehaus.plexus.utils.interpolation are not self-contained
Posted by Benjamin Bentmann <be...@udo.edu>.
Vincent Siveton schrieb:
> In a 2.0 case, we need to sync some classes (PLXUTILS-21)
I removed the interpolation stuff and followed Arnaud's advice to bump
the version to 2.0.
Let me repeat that the removal of the interpolation classes was to get
plexus-utils back into an easy shape, without shading and the potential
for weird class loading issues. For this reason, I'm -1 on the proposal
in PLXUTILS-21 about using the Shade Plugin to simply replace a bunch of
classes with stuff from other libs. Developers that seek the
functionality from commons-whatever can use those libs directly.
The stuff in plexus-utils has partly diverged from its original sources,
to address needs that were driven by Maven, like incremental building.
So blindly replacing our stuff with something external imposes the risk
to revert our enhancements. Whatever improvements we want to consume
from those libs for plexus-utils should therefore be copied at the
source-level, where we have diffs that can be reviewed for their effect
regarding backward-compat.
I would like plexus-utils:2.0 to be an easy upgrade, where plugins would
basically depend on plexus-interpolation where required and fix their
imports by pressing a shortcut in their IDE. So please consider
carefully what you want to sync with the external libs.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [plexus-dev] [jira] Created: (PLXUTILS-117) The classes from
org.codehaus.plexus.utils.interpolation are not self-contained
Posted by Vincent Siveton <vi...@gmail.com>.
2009/8/23 Benjamin Bentmann <be...@udo.edu>:
> Arnaud HERITIER wrote:
>
>> In theory, we remove things only in a major version (2.0).
>
> That's fine, so we'll call it 2.0.
In a 2.0 case, we need to sync some classes (PLXUTILS-21)
Cheers,
Vincent
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [plexus-dev] [jira] Created: (PLXUTILS-117) The classes from
org.codehaus.plexus.utils.interpolation are not self-contained
Posted by Benjamin Bentmann <be...@udo.edu>.
Arnaud HERITIER wrote:
> In theory, we remove things only in a major version (2.0).
That's fine, so we'll call it 2.0.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [plexus-dev] [jira] Created: (PLXUTILS-117) The classes from
org.codehaus.plexus.utils.interpolation are not self-contained
Posted by Arnaud HERITIER <ah...@gmail.com>.
In theory, we remove things only in a major version (2.0).Otherwise : +1
Cheers,
Arnaud
# Arnaud Héritier
# Software Factory Manager
# eXo Platform
# http://www.exoplatform.com
# http://blog.aheritier.net
On Sat, Aug 22, 2009 at 5:44 PM, Benjamin Bentmann <
benjamin.bentmann@udo.edu> wrote:
> The classes from org.codehaus.plexus.utils.interpolation are not
>> self-contained
>>
>> -------------------------------------------------------------------------------
>>
>> Key: PLXUTILS-117
>> URL: http://jira.codehaus.org/browse/PLXUTILS-117
>> Project: Plexus Utils
>> Issue Type: Bug
>> Affects Versions: 1.5.15
>> Reporter: Benjamin Bentmann
>> Attachments: pu-vs-pi.zip
>>
>> [r8255|http://fisheye.codehaus.org/changelog/plexus/?cs=8255] caused
>> exclusion of the plexus-interpolation classes from the plexus-utils JAR.
>> This in turn makes usage of the {{org.codehaus.plexus.utils.intepolation.*}}
>> classes from a standalone plexus-utils JAR impossible as their super classes
>> can't be resolved. See the attached demo project that fails upon "mvn clean
>> compile".
>>
>> Note sure whether the change in the above commit was actually necessary
>> given that previous plexus-utils versions like 1.5.12 apparently shipped
>> with a [dependency reduced POM|
>> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.5.12/plexus-utils-1.5.12.pom]
>> that already declared plexus-interpolation as provided.
>>
>> Declaring plexus-interpolation as provided in the original POM causes the
>> dependency to be ignored by the Shade Plugin because that uses
>> {{@requiresDependencyResolution runtime}} but provided dependencies are not
>> resolved for this resolution scope...
>>
>>
> How about if we just remove the org.codehaus.plexus.utils.intepolation
> package from plexus-utils, bump the version number for plexus-utils to 1.6
> and get back to a simple project that doesn't need fancy shading?
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [plexus-dev] [jira] Created: (PLXUTILS-117) The classes from
org.codehaus.plexus.utils.interpolation are not self-contained
Posted by John Casey <jd...@commonjava.org>.
+1
Benjamin Bentmann wrote:
>> The classes from org.codehaus.plexus.utils.interpolation are not
>> self-contained
>> -------------------------------------------------------------------------------
>>
>>
>> Key: PLXUTILS-117
>> URL: http://jira.codehaus.org/browse/PLXUTILS-117
>> Project: Plexus Utils
>> Issue Type: Bug
>> Affects Versions: 1.5.15
>> Reporter: Benjamin Bentmann
>> Attachments: pu-vs-pi.zip
>>
>> [r8255|http://fisheye.codehaus.org/changelog/plexus/?cs=8255] caused
>> exclusion of the plexus-interpolation classes from the plexus-utils
>> JAR. This in turn makes usage of the
>> {{org.codehaus.plexus.utils.intepolation.*}} classes from a standalone
>> plexus-utils JAR impossible as their super classes can't be resolved.
>> See the attached demo project that fails upon "mvn clean compile".
>>
>> Note sure whether the change in the above commit was actually
>> necessary given that previous plexus-utils versions like 1.5.12
>> apparently shipped with a [dependency reduced
>> POM|http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.5.12/plexus-utils-1.5.12.pom]
>> that already declared plexus-interpolation as provided.
>>
>> Declaring plexus-interpolation as provided in the original POM causes
>> the dependency to be ignored by the Shade Plugin because that uses
>> {{@requiresDependencyResolution runtime}} but provided dependencies
>> are not resolved for this resolution scope...
>>
>
> How about if we just remove the org.codehaus.plexus.utils.intepolation
> package from plexus-utils, bump the version number for plexus-utils to
> 1.6 and get back to a simple project that doesn't need fancy shading?
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org