You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/15 14:15:31 UTC
[GitHub] [arrow] jackylee-ch opened a new pull request, #13161: ARROW-16568: [JAVA] Enable skip BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf
jackylee-ch opened a new pull request, #13161:
URL: https://github.com/apache/arrow/pull/13161
We have BOUNDS_CHECKING_SKIP in ArrowBuf.setByte or ArrowBuf.getByte, it helps to remove unexpected bounds checks. However, it doesn't exists in ArrowBuf.setBytes or ArrowBuf.getBytes, which makes 10% cpu time cost for checking bounds in our environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #13161: ARROW-16568: [Java] Enable skipping BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #13161: ARROW-16568: [Java] Enable skipping BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf
URL: https://github.com/apache/arrow/pull/13161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jackylee-ch commented on pull request #13161: ARROW-16568: [Java] Enable skip BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf
Posted by GitBox <gi...@apache.org>.
jackylee-ch commented on PR #13161:
URL: https://github.com/apache/arrow/pull/13161#issuecomment-1127705653
<img width="1418" alt="image" src="https://user-images.githubusercontent.com/10897625/168606455-d63f82c5-3e41-4f03-ac76-2a737f2ec73f.png">
This is the perf image for this problem, we set about billiions of String values into StringVector. As showing in image, we have 14% cpu time cost with checkIndex, which is actually unneccesary and no reallocat found. With this pr, we have 14% speed up in our environment.
BTW, We have chagned setSafe to set to remove the handleSafe costs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13161: ARROW-16568: [JAVA] Enable skip BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13161:
URL: https://github.com/apache/arrow/pull/13161#issuecomment-1126950855
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13161: ARROW-16568: [JAVA] Enable skip BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13161:
URL: https://github.com/apache/arrow/pull/13161#issuecomment-1126950850
https://issues.apache.org/jira/browse/ARROW-16568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org