[GitHub] [trafficcontrol] mitchell852 commented on pull request #5848: User Permissions Blueprint

[GitBox <gi...@apache.org>]

mitchell852 commented on pull request #5848:
URL: https://github.com/apache/trafficcontrol/pull/5848#issuecomment-890127894


   > Check if the user is trying to delete their own lock. If so, check the user’s role(and perms). If they have the `cdn-locks-delete-cap` permission, then let them proceed with the request.
   > However, if the user is trying to delete somebody else’s lock, check to see if they have the `cdn-locks-admin-delete-cap` . If they have it, then proceed with the request. If not, then return a 403.
   
   i would just suggest that the "cap" aka permission is named intuitively. `cdn-locks-admin-delete-cap` doesn't mean anything to me and it has a "role" embedded in the name which seems like a no-no. this would make more sense to me: `cdn-locks-delete` permission (to delete your own locks) and `cdn-locks-delete-all` permission (to delete any/all locks). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org