You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/21 04:38:39 UTC
[GitHub] [skywalking] dengliming opened a new pull request #4390: Fix
otherMetricsDataTTL config not working
dengliming opened a new pull request #4390: Fix otherMetricsDataTTL config not working
URL: https://github.com/apache/skywalking/pull/4390
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
There is no setter of otherMetricsDataTTL method in StorageModuleElasticsearchConfig.This can lead to dayMetrics only stored 2 days default.
See [https://github.com/apache/skywalking/issues/4388](https://github.com/apache/skywalking/issues/4388)
- How to fix?
Add setter annotation.
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng closed pull request #4390: Fix
otherMetricsDataTTL config not working
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #4390: Fix otherMetricsDataTTL config not working
URL: https://github.com/apache/skywalking/pull/4390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4390: Fix
otherMetricsDataTTL config not working
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4390: Fix otherMetricsDataTTL config not working
URL: https://github.com/apache/skywalking/pull/4390#issuecomment-589494918
Please make your commit log clear. Such as creating a new branch from the latest upstream master.. And why we need the setter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services