You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2023/08/17 04:17:12 UTC
[GitHub] [arrow-rs] liurenjie1024 opened a new issue, #4708: bug: DataType's contains method should consider decimal's precision and scale.
liurenjie1024 opened a new issue, #4708:
URL: https://github.com/apache/arrow-rs/issues/4708
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
```rust
let a = DataType::Decimal(28, 10);
let b = DataType::Decimal(20, 10);
assert!(a.contains(b));
```
The above assertation failed, but a is a superset of b.
**To Reproduce**
<!--
Steps to reproduce the behavior:
-->
See above code.
**Expected behavior**
<!--
A clear and concise description of what you expected to happen.
-->
It should not fail.
**Additional context**
<!--
Add any other context about the problem here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liurenjie1024 commented on issue #4708: bug: DataType's contains method should consider decimal's precision and scale.
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #4708:
URL: https://github.com/apache/arrow-rs/issues/4708#issuecomment-1681720875
The definition of supertype is kind of confusing, I think sth like compatible type maybe better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on issue #4708: bug: DataType's contains method should consider decimal's precision and scale.
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #4708:
URL: https://github.com/apache/arrow-rs/issues/4708#issuecomment-1681707681
I think `contains` checks superset only for nested type. For primitive types, the function simply checks two types are same or not. How do you define "contains" between two primitive types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liurenjie1024 closed issue #4708: bug: DataType's contains method should consider decimal's precision and scale.
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #4708: bug: DataType's contains method should consider decimal's precision and scale.
URL: https://github.com/apache/arrow-rs/issues/4708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org