You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/01/14 12:11:56 UTC
[GitHub] codecov-io edited a comment on issue #138: [LIVY-547]do not check
expire when session in state busy
codecov-io edited a comment on issue #138: [LIVY-547]do not check expire when session in state busy
URL: https://github.com/apache/incubator-livy/pull/138#issuecomment-453984602
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/138?src=pr&el=h1) Report
> Merging [#138](https://codecov.io/gh/apache/incubator-livy/pull/138?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/02550f7919b7348b6a7270cf806e031670037b2f?src=pr&el=desc) will **increase** coverage by `0.26%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/138?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #138 +/- ##
===========================================
+ Coverage 68.34% 68.6% +0.26%
- Complexity 895 896 +1
===========================================
Files 100 100
Lines 5604 5606 +2
Branches 840 841 +1
===========================================
+ Hits 3830 3846 +16
+ Misses 1225 1209 -16
- Partials 549 551 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/138?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cala/org/apache/livy/sessions/SessionManager.scala](https://codecov.io/gh/apache/incubator-livy/pull/138/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXNzaW9ucy9TZXNzaW9uTWFuYWdlci5zY2FsYQ==) | `83.13% <100%> (+0.41%)` | `23 <0> (ø)` | :arrow_down: |
| [.../scala/org/apache/livy/sessions/SessionState.scala](https://codecov.io/gh/apache/incubator-livy/pull/138/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvU2Vzc2lvblN0YXRlLnNjYWxh) | `58.33% <0%> (-2.78%)` | `2% <0%> (ø)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/138/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.23% <0%> (ø)` | `42% <0%> (ø)` | :arrow_down: |
| [...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/138/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==) | `66.01% <0%> (+1.94%)` | `13% <0%> (ø)` | :arrow_down: |
| [...scala/org/apache/livy/repl/SparkRInterpreter.scala](https://codecov.io/gh/apache/incubator-livy/pull/138/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9TcGFya1JJbnRlcnByZXRlci5zY2FsYQ==) | `60.69% <0%> (+2.31%)` | `14% <0%> (ø)` | :arrow_down: |
| [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/138/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `75.15% <0%> (+2.48%)` | `20% <0%> (+1%)` | :arrow_up: |
| [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/138/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `33.33% <0%> (+2.56%)` | `7% <0%> (ø)` | :arrow_down: |
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/138/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `55.88% <0%> (+5.88%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/138?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/138?src=pr&el=footer). Last update [02550f7...768dfba](https://codecov.io/gh/apache/incubator-livy/pull/138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services