You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2024/05/09 00:34:51 UTC
[PR] [VL] Substrait-to-Velox: Support nested complex type signature parsing [incubator-gluten]
zhztheplayer opened a new pull request, #5665:
URL: https://github.com/apache/incubator-gluten/pull/5665
For example:
Signature:
```
struct<fp32,struct<struct<i8,dec<19,2>,list<i32>,map<i16,i32>>>>
```
Error:
```
unknown file: Failure
C++ exception with description "Exception: VeloxUserError
Error Source: USER
Error Code: UNSUPPORTED
Reason: Substrait type signature conversion to Velox type not supported for i32>,map<i16,i32>>.
```
The patch works relevant code a bit and fixes the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Substrait-to-Velox: Support nested complex type signature parsing [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #5665:
URL: https://github.com/apache/incubator-gluten/pull/5665#issuecomment-2101718556
cc @rui-mo @WangGuangxin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Substrait-to-Velox: Support nested complex type signature parsing [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5665:
URL: https://github.com/apache/incubator-gluten/pull/5665#issuecomment-2101774942
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5665_time.csv</font></td>
<td><font color=#000000>log/native_master_05_08_2024_e5f1e5edf_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>36.08</font></td>
<td><font color=#6F9915>35.03</font></td>
<td><font color=#6F9915>-1.047</font></td>
<td><font color=#6F9915>97.10%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>24.11</font></td>
<td><font color=#6F9915>21.91</font></td>
<td><font color=#6F9915>-2.201</font></td>
<td><font color=#6F9915>90.87%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>36.58</font></td>
<td><font color=#6F9915>36.38</font></td>
<td><font color=#6F9915>-0.202</font></td>
<td><font color=#6F9915>99.45%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>37.94</font></td>
<td><font color=#F92663>38.35</font></td>
<td><font color=#F92663>0.420</font></td>
<td><font color=#F92663>101.11%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>70.61</font></td>
<td><font color=#F92663>71.54</font></td>
<td><font color=#F92663>0.936</font></td>
<td><font color=#F92663>101.33%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q6</font></td>
<td><font color=#6F9915>7.30</font></td>
<td><font color=#6F9915>5.99</font></td>
<td><font color=#6F9915>-1.307</font></td>
<td><font color=#6F9915>82.10%</font></td>
</tr>
<tr>
<td><font color=#F92663>q7</font></td>
<td><font color=#F92663>83.44</font></td>
<td><font color=#F92663>83.77</font></td>
<td><font color=#F92663>0.322</font></td>
<td><font color=#F92663>100.39%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>85.34</font></td>
<td><font color=#F92663>85.53</font></td>
<td><font color=#F92663>0.193</font></td>
<td><font color=#F92663>100.23%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>124.32</font></td>
<td><font color=#6F9915>122.85</font></td>
<td><font color=#6F9915>-1.465</font></td>
<td><font color=#6F9915>98.82%</font></td>
</tr>
<tr>
<td><font color=#F92663>q10</font></td>
<td><font color=#F92663>43.98</font></td>
<td><font color=#F92663>46.15</font></td>
<td><font color=#F92663>2.171</font></td>
<td><font color=#F92663>104.94%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>20.30</font></td>
<td><font color=#F92663>20.42</font></td>
<td><font color=#F92663>0.124</font></td>
<td><font color=#F92663>100.61%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>27.12</font></td>
<td><font color=#6F9915>23.69</font></td>
<td><font color=#6F9915>-3.431</font></td>
<td><font color=#6F9915>87.35%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>57.23</font></td>
<td><font color=#6F9915>55.18</font></td>
<td><font color=#6F9915>-2.051</font></td>
<td><font color=#6F9915>96.42%</font></td>
</tr>
<tr>
<td><font color=#F92663>q14</font></td>
<td><font color=#F92663>19.28</font></td>
<td><font color=#F92663>19.54</font></td>
<td><font color=#F92663>0.262</font></td>
<td><font color=#F92663>101.36%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>31.25</font></td>
<td><font color=#6F9915>30.65</font></td>
<td><font color=#6F9915>-0.601</font></td>
<td><font color=#6F9915>98.08%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q16</font></td>
<td><font color=#6F9915>13.91</font></td>
<td><font color=#6F9915>13.73</font></td>
<td><font color=#6F9915>-0.173</font></td>
<td><font color=#6F9915>98.75%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>101.54</font></td>
<td><font color=#F92663>103.15</font></td>
<td><font color=#F92663>1.603</font></td>
<td><font color=#F92663>101.58%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>145.66</font></td>
<td><font color=#F92663>146.63</font></td>
<td><font color=#F92663>0.975</font></td>
<td><font color=#F92663>100.67%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.50</font></td>
<td><font color=#F92663>14.98</font></td>
<td><font color=#F92663>1.476</font></td>
<td><font color=#F92663>110.93%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>28.72</font></td>
<td><font color=#6F9915>28.36</font></td>
<td><font color=#6F9915>-0.358</font></td>
<td><font color=#6F9915>98.75%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>285.72</font></td>
<td><font color=#6F9915>283.86</font></td>
<td><font color=#6F9915>-1.856</font></td>
<td><font color=#6F9915>99.35%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>14.62</font></td>
<td><font color=#F92663>15.84</font></td>
<td><font color=#F92663>1.213</font></td>
<td><font color=#F92663>108.29%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1308.53</font></td>
<td><font color=#6F9915>1303.53</font></td>
<td><font color=#6F9915>-4.997</font></td>
<td><font color=#6F9915>99.62%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Substrait-to-Velox: Support nested complex type signature parsing [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #5665:
URL: https://github.com/apache/incubator-gluten/pull/5665#issuecomment-2101727267
/Benchmark Velox
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Substrait-to-Velox: Support nested complex type signature parsing [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #5665:
URL: https://github.com/apache/incubator-gluten/pull/5665#issuecomment-2101854559
Another error seems unrelated from CI
```
2024-05-09T03:05:12.2651692Z GlutenOrcV1QuerySuite:
2024-05-09T03:05:12.4586855Z pure virtual method called
2024-05-09T03:05:12.4587498Z terminate called without an active exception
```
https://github.com/apache/incubator-gluten/actions/runs/9010634143/job/24757007441?pr=5665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Substrait-to-Velox: Support nested complex type signature parsing [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer merged PR #5665:
URL: https://github.com/apache/incubator-gluten/pull/5665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Substrait-to-Velox: Support nested complex type signature parsing [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5665:
URL: https://github.com/apache/incubator-gluten/pull/5665#issuecomment-2101717263
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org