You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/07/23 00:23:49 UTC
[jira] Created: (HBASE-2867) Have master show its address using
hostname rather than IP
Have master show its address using hostname rather than IP
----------------------------------------------------------
Key: HBASE-2867
URL: https://issues.apache.org/jira/browse/HBASE-2867
Project: HBase
Issue Type: Improvement
Reporter: stack
Priority: Trivial
Fix For: 0.90.0
Here is the patch:
{code}
diff --git a/src/main/java/org/apache/hadoop/hbase/HServerAddress.java b/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
index 763eca2..3859968 100644
--- a/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
+++ b/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
@@ -46,7 +46,7 @@ public class HServerAddress implements WritableComparable<HServerAddress> {
*/
public HServerAddress(InetSocketAddress address) {
this.address = address;
- this.stringValue = address.getAddress().getHostAddress() + ":" +
+ this.stringValue = address.getAddress().getHostName() + ":" +
address.getPort();
checkBindAddressCanBeResolved();
}
{code}
This change will effect what is shown in log when master starts up printing its hostname instead of address and it will also show over in NN logs -- using hostname rather than IP will match what the RS is showing in NN log.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2867) Have master show its address using
hostname rather than IP
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2867:
-------------------------
Status: Patch Available (was: Open)
Marking patch available so get attention
> Have master show its address using hostname rather than IP
> ----------------------------------------------------------
>
> Key: HBASE-2867
> URL: https://issues.apache.org/jira/browse/HBASE-2867
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Priority: Trivial
> Fix For: 0.90.0
>
>
> Here is the patch:
> {code}
> diff --git a/src/main/java/org/apache/hadoop/hbase/HServerAddress.java b/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> index 763eca2..3859968 100644
> --- a/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> +++ b/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> @@ -46,7 +46,7 @@ public class HServerAddress implements WritableComparable<HServerAddress> {
> */
> public HServerAddress(InetSocketAddress address) {
> this.address = address;
> - this.stringValue = address.getAddress().getHostAddress() + ":" +
> + this.stringValue = address.getAddress().getHostName() + ":" +
> address.getPort();
> checkBindAddressCanBeResolved();
> }
> {code}
> This change will effect what is shown in log when master starts up printing its hostname instead of address and it will also show over in NN logs -- using hostname rather than IP will match what the RS is showing in NN log.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2867) Have master show its address using
hostname rather than IP
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2867:
-------------------------
Status: Resolved (was: Patch Available)
Assignee: stack
Resolution: Fixed
Committed as part of HBASE-2692
> Have master show its address using hostname rather than IP
> ----------------------------------------------------------
>
> Key: HBASE-2867
> URL: https://issues.apache.org/jira/browse/HBASE-2867
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Priority: Trivial
> Fix For: 0.90.0
>
>
> Here is the patch:
> {code}
> diff --git a/src/main/java/org/apache/hadoop/hbase/HServerAddress.java b/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> index 763eca2..3859968 100644
> --- a/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> +++ b/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> @@ -46,7 +46,7 @@ public class HServerAddress implements WritableComparable<HServerAddress> {
> */
> public HServerAddress(InetSocketAddress address) {
> this.address = address;
> - this.stringValue = address.getAddress().getHostAddress() + ":" +
> + this.stringValue = address.getAddress().getHostName() + ":" +
> address.getPort();
> checkBindAddressCanBeResolved();
> }
> {code}
> This change will effect what is shown in log when master starts up printing its hostname instead of address and it will also show over in NN logs -- using hostname rather than IP will match what the RS is showing in NN log.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2867) Have master show its address using
hostname rather than IP
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891399#action_12891399 ]
stack commented on HBASE-2867:
------------------------------
I need to test. J-D points out this toString is actually used in a few critical places. Using hostname instead should be fine but test.
> Have master show its address using hostname rather than IP
> ----------------------------------------------------------
>
> Key: HBASE-2867
> URL: https://issues.apache.org/jira/browse/HBASE-2867
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Priority: Trivial
> Fix For: 0.90.0
>
>
> Here is the patch:
> {code}
> diff --git a/src/main/java/org/apache/hadoop/hbase/HServerAddress.java b/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> index 763eca2..3859968 100644
> --- a/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> +++ b/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
> @@ -46,7 +46,7 @@ public class HServerAddress implements WritableComparable<HServerAddress> {
> */
> public HServerAddress(InetSocketAddress address) {
> this.address = address;
> - this.stringValue = address.getAddress().getHostAddress() + ":" +
> + this.stringValue = address.getAddress().getHostName() + ":" +
> address.getPort();
> checkBindAddressCanBeResolved();
> }
> {code}
> This change will effect what is shown in log when master starts up printing its hostname instead of address and it will also show over in NN logs -- using hostname rather than IP will match what the RS is showing in NN log.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.