You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/28 09:33:25 UTC

[GitHub] [airflow] XD-DENG edited a comment on issue #6682: [AIRFLOW-6088] pass DAG processing runtime as duration to stats

XD-DENG edited a comment on issue #6682: [AIRFLOW-6088] pass DAG processing runtime as duration to stats
URL: https://github.com/apache/airflow/pull/6682#issuecomment-559415137
 
 
   Hi @hoesler ,
   I found one more: https://github.com/apache/airflow/blob/109789283dfda76649fafb7535fee82300e95d28/airflow/models/dagrun.py#L309-L310
   
   Instead of getting `.total_seconds()` then times 1000, I think we can directly pass `timezone.utcnow() - start_dttm` to `Stats.timing()`.
   
   May you address this together in this PR? Cheers.
   
   All other related lines in the code base seems ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services