You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2024/09/04 17:31:58 UTC
[PR] OAK-11078: Remove usage of Guava checkArgument [jackrabbit-oak]
reschke opened a new pull request, #1687:
URL: https://github.com/apache/jackrabbit-oak/pull/1687
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11078: Remove usage of Guava checkArgument [jackrabbit-oak]
Posted by "mbaedke (via GitHub)" <gi...@apache.org>.
mbaedke commented on code in PR #1687:
URL: https://github.com/apache/jackrabbit-oak/pull/1687#discussion_r1746699357
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java:
##########
@@ -244,8 +244,8 @@ public static String checkValidName(String asyncName){
if (IndexConstants.ASYNC_REINDEX_VALUE.equals(asyncName)){
return asyncName;
}
- checkArgument(asyncName.endsWith("async"), "async name [%s] does not confirm to " +
- "naming pattern of ending with 'async'", asyncName);
+ Validate.isTrue(asyncName.endsWith("async"), "async name [%s] does not confirm to naming pattern of ending with 'async'",
Review Comment:
s/confirm/conform
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/JournalEntry.java:
##########
@@ -700,7 +700,7 @@ private static final class TreeNode {
}
TreeNode(MapFactory mapFactory, TreeNode parent, String name) {
- checkArgument(!name.contains("/"),
+ Validate.isTrue(!name.contains("/"),
Review Comment:
Does "{}" even work in a format string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11078: Remove usage of Guava checkArgument [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #1687:
URL: https://github.com/apache/jackrabbit-oak/pull/1687#discussion_r1746721975
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/JournalEntry.java:
##########
@@ -700,7 +700,7 @@ private static final class TreeNode {
}
TreeNode(MapFactory mapFactory, TreeNode parent, String name) {
- checkArgument(!name.contains("/"),
+ Validate.isTrue(!name.contains("/"),
Review Comment:
No, according to the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11078: Remove usage of Guava checkArgument [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #1687:
URL: https://github.com/apache/jackrabbit-oak/pull/1687#discussion_r1746721975
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/JournalEntry.java:
##########
@@ -700,7 +700,7 @@ private static final class TreeNode {
}
TreeNode(MapFactory mapFactory, TreeNode parent, String name) {
- checkArgument(!name.contains("/"),
+ Validate.isTrue(!name.contains("/"),
Review Comment:
No, according to the documentation (even in checkArgument)
so yes, this needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11078: Remove usage of Guava checkArgument [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke closed pull request #1687: OAK-11078: Remove usage of Guava checkArgument
URL: https://github.com/apache/jackrabbit-oak/pull/1687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org