You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/12 12:16:38 UTC
[GitHub] [mynewt-nimble] utzig opened a new pull request #772: Style check
utzig opened a new pull request #772: Style check
URL: https://github.com/apache/mynewt-nimble/pull/772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] utzig merged pull request #772: Add CI style
checking
Posted by GitBox <gi...@apache.org>.
utzig merged pull request #772: Add CI style checking
URL: https://github.com/apache/mynewt-nimble/pull/772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #772: Add CI
style checking
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #772: Add CI style checking
URL: https://github.com/apache/mynewt-nimble/pull/772#issuecomment-598273788
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #772:
Add CI style checking
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #772: Add CI style checking
URL: https://github.com/apache/mynewt-nimble/pull/772#issuecomment-598248525
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/test/src/ble_gatts_reg_test.c
<details>
```diff
@@ -135,7 +135,7 @@
int i;
switch (entry->op) {
- case BLE_GATT_REGISTER_OP_SVC:
+ case BLE_GATT_REGISTER_OP_SVC:
/* Wrong service UUID. */
ble_uuid_to_any(entry->svc->uuid, &wrong_uuid);
wrong_uuid.u16.value++;
@@ -157,8 +157,7 @@
TEST_ASSERT(rc == BLE_HS_ENOENT);
/* Existing (but wrong) service, correct characteristic UUID. */
- for (i = 0; i < ble_gatts_reg_test_num_entries; i++)
- {
+ for (i = 0; i < ble_gatts_reg_test_num_entries; i++) {
cur = ble_gatts_reg_test_entries + i;
switch (cur->op) {
case BLE_GATT_REGISTER_OP_SVC:
@@ -276,8 +275,9 @@
/* Verify that characteristic value handle was properly assigned at
* registration.
*/
- if (op ==BLE_GATT_REGISTER_OP_CHR)
+ if (op == BLE_GATT_REGISTER_OP_CHR) {
TEST_ASSERT(*entry->chr->val_handle == entry->val_handle);
+ }
/* Verify that the entry can be looked up. */
ble_gatts_reg_test_misc_lookup_good(entry);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #772: DNM -
Style check
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #772: DNM - Style check
URL: https://github.com/apache/mynewt-nimble/pull/772#issuecomment-598248525
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/test/src/ble_gatts_reg_test.c
<details>
```diff
@@ -135,7 +135,7 @@
int i;
switch (entry->op) {
- case BLE_GATT_REGISTER_OP_SVC:
+ case BLE_GATT_REGISTER_OP_SVC:
/* Wrong service UUID. */
ble_uuid_to_any(entry->svc->uuid, &wrong_uuid);
wrong_uuid.u16.value++;
@@ -157,8 +157,7 @@
TEST_ASSERT(rc == BLE_HS_ENOENT);
/* Existing (but wrong) service, correct characteristic UUID. */
- for (i = 0; i < ble_gatts_reg_test_num_entries; i++)
- {
+ for (i = 0; i < ble_gatts_reg_test_num_entries; i++) {
cur = ble_gatts_reg_test_entries + i;
switch (cur->op) {
case BLE_GATT_REGISTER_OP_SVC:
@@ -276,8 +275,9 @@
/* Verify that characteristic value handle was properly assigned at
* registration.
*/
- if (op ==BLE_GATT_REGISTER_OP_CHR)
+ if (op == BLE_GATT_REGISTER_OP_CHR) {
TEST_ASSERT(*entry->chr->val_handle == entry->val_handle);
+ }
/* Verify that the entry can be looked up. */
ble_gatts_reg_test_misc_lookup_good(entry);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services