You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "PleaseGiveMeTheCoke (via GitHub)" <gi...@apache.org> on 2024/11/10 07:24:12 UTC
[PR] Add grpc serializer [incubator-seata]
PleaseGiveMeTheCoke opened a new pull request, #6992:
URL: https://github.com/apache/incubator-seata/pull/6992
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
https://github.com/apache/incubator-seata/issues/6990
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] Add grpc serializer [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #6992:
URL: https://github.com/apache/incubator-seata/pull/6992#issuecomment-2466624651
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `5.55556%` with `17 lines` in your changes missing coverage. Please review.
> Project coverage is 52.68%. Comparing base [(`835ef47`)](https://app.codecov.io/gh/apache/incubator-seata/commit/835ef47448c1c0819552297bd3c45d61125edcd5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`45c71ea`)](https://app.codecov.io/gh/apache/incubator-seata/commit/45c71ea2da7ab4929ef90bd2fd62170b175385aa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/seata/serializer/protobuf/GrpcSerializer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&filepath=serializer%2Fseata-serializer-protobuf%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fserializer%2Fprotobuf%2FGrpcSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VyaWFsaXplci9zZWF0YS1zZXJpYWxpemVyLXByb3RvYnVmL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zZXJpYWxpemVyL3Byb3RvYnVmL0dycGNTZXJpYWxpemVyLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6992 +/- ##
============================================
+ Coverage 52.67% 52.68% +0.01%
- Complexity 6572 6578 +6
============================================
Files 1125 1126 +1
Lines 39924 39942 +18
Branches 4676 4680 +4
============================================
+ Hits 21031 21045 +14
- Misses 16897 16899 +2
- Partials 1996 1998 +2
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...g/apache/seata/core/serializer/SerializerType.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&filepath=core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcore%2Fserializer%2FSerializerType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9zZXJpYWxpemVyL1NlcmlhbGl6ZXJUeXBlLmphdmE=) | `69.56% <100.00%> (+1.38%)` | :arrow_up: |
| [...ache/seata/serializer/protobuf/GrpcSerializer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&filepath=serializer%2Fseata-serializer-protobuf%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fserializer%2Fprotobuf%2FGrpcSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VyaWFsaXplci9zZWF0YS1zZXJpYWxpemVyLXByb3RvYnVmL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zZXJpYWxpemVyL3Byb3RvYnVmL0dycGNTZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6992/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] feature: add grpc serializer [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6992:
URL: https://github.com/apache/incubator-seata/pull/6992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org