[GitHub] [superset] kgabryje commented on pull request #19064: perf(dashboard): Improve performance of complex dashboards

[GitBox <gi...@apache.org>]

kgabryje commented on pull request #19064:
URL: https://github.com/apache/superset/pull/19064#issuecomment-1062788333


   > @kgabryje Thank you for the perf improvement! just 1 question here: I saw both `getChartIdsInFilterBoxScope` and `getChartIdsInFilterScope` functions. So when to use each of them?
   
   @graceguo-supercat I kept `getChartIdsInFilterBoxScope` because refactoring the logic related to filter box would be risky as that code is quite complex - I decided not to do it since we're on the road of deprecating filter box in favour in native filters. I added a comment to `getChartIdsInFilterBoxScope` that redirects to the new `getChartIdsInFilterScope`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org