[GitHub] [carbondata] ravipesala commented on a change in pull request #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias

[GitBox <gi...@apache.org>]

ravipesala commented on a change in pull request #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias
URL: https://github.com/apache/carbondata/pull/3122#discussion_r282931593
 
 

 ##########
 File path: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/util/BirdcageOptimizer.scala
 ##########
 @@ -156,6 +159,53 @@ object BirdcageOptimizer extends RuleExecutor[LogicalPlan] {
   }
 }
 
+// This class is used to optimize the filter condition
+// If all of the conditions have alias on the aggregate expressions
+// it will be pull up and exchange the alias to match the MV
+object MVPredicateAlias extends Rule[LogicalPlan] with PredicateHelper {
 
 Review comment:
   Whatever is pushdown in `PushDownPredicate` you are trying to pull up using this rule. Please just remove the `PushDownPredicate` from the optimizer will solve all having clause issues.  But the only issue will be with filter query on groupby queries , I think that issue can be fixed in MV module instead of adding a rule.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services