You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by bp...@apache.org on 2021/01/05 05:33:15 UTC
[ranger] branch master updated: RANGER-3028:
Upgrade-Maven-PMD-plugin-version-to-3.14.0
This is an automated email from the ASF dual-hosted git repository.
bpatel pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git
The following commit(s) were added to refs/heads/master by this push:
new 6e2d66a RANGER-3028: Upgrade-Maven-PMD-plugin-version-to-3.14.0
6e2d66a is described below
commit 6e2d66a856b33ae70c078875645f38b0cac54114
Author: Bhavik Patel <bh...@gmail.com>
AuthorDate: Tue Jan 5 10:22:00 2021 +0530
RANGER-3028: Upgrade-Maven-PMD-plugin-version-to-3.14.0
---
dev-support/ranger-pmd-ruleset.xml | 108 +++++++++++++++----
pom.xml | 2 +-
ranger-examples/dev-support/ranger-pmd-ruleset.xml | 114 ++++++++++++++++-----
security-admin/pom.xml | 6 +-
4 files changed, 181 insertions(+), 49 deletions(-)
diff --git a/dev-support/ranger-pmd-ruleset.xml b/dev-support/ranger-pmd-ruleset.xml
index 65a4f1d..88d77f2 100644
--- a/dev-support/ranger-pmd-ruleset.xml
+++ b/dev-support/ranger-pmd-ruleset.xml
@@ -24,27 +24,97 @@
Apache Ranger - PMD rule set
</description>
- <rule ref="rulesets/java/basic.xml">
- <exclude name="AvoidUsingHardCodedIP" />
- <exclude name="CollapsibleIfStatements" />
- <exclude name="DoubleCheckedLocking" />
- <exclude name="OverrideBothEqualsAndHashcode" />
- </rule>
- <rule ref="rulesets/java/unusedcode.xml" />
- <rule ref="rulesets/java/imports.xml">
+ <rule ref="category/java/codestyle.xml">
+ <!-- TODO: can be Handle -->
+ <exclude name="UnnecessaryLocalBeforeReturn" />
+ <exclude name="UnnecessaryModifier" />
+ <exclude name="UnnecessaryConstructor" />
+ <exclude name="UnnecessaryFullyQualifiedName" />
+ <exclude name="UnnecessaryAnnotationValueElement" />
+ <exclude name="LocalVariableNamingConventions" />
+ <exclude name="AvoidDollarSigns" />
+ <exclude name="ClassNamingConventions" />
+ <exclude name="UnnecessaryCast" />
+ <!-- Nothing -->
+ <exclude name="LocalVariableCouldBeFinal" />
+ <exclude name="MethodArgumentCouldBeFinal" />
+ <exclude name="ShortVariable" />
+ <exclude name="LongVariable" />
+ <exclude name="IdenticalCatchBranches" />
+ <exclude name="ControlStatementBraces" />
+ <exclude name="UselessParentheses" />
+ <exclude name="FieldNamingConventions" />
+ <exclude name="ConfusingTernary" />
+ <exclude name="OnlyOneReturn" />
+ <exclude name="AtLeastOneConstructor" />
+ <exclude name="PrematureDeclaration" />
+ <exclude name="CallSuperInConstructor" />
+ <exclude name="DefaultPackage" />
+ <exclude name="CommentDefaultAccessModifier" />
+ <exclude name="UseDiamondOperator" />
+ <exclude name="FieldDeclarationsShouldBeAtStartOfClass" />
+ <exclude name="BooleanGetMethodName" />
+ <exclude name="EmptyMethodInAbstractClassShouldBeAbstract" />
+ <exclude name="UseUnderscoresInNumericLiterals" />
+ <exclude name="MethodNamingConventions" />
+ <exclude name="UseShortArrayInitializer" />
+ <exclude name="LinguisticNaming" />
+ <exclude name="ShortClassName" />
+ <exclude name="FormalParameterNamingConventions" />
+ <exclude name="ShortMethodName" />
+ <exclude name="PackageCase" />
+ <exclude name="GenericsNaming" />
<exclude name="TooManyStaticImports" />
</rule>
- <rule ref="rulesets/java/braces.xml">
- <exclude name="ForLoopsMustUseBraces" />
- <exclude name="IfElseStmtsMustUseBraces" />
- <exclude name="IfStmtsMustUseBraces" />
- </rule>
- <rule ref="rulesets/java/empty.xml">
- <exclude name="EmptyCatchBlock" />
- </rule>
- <rule ref="rulesets/java/migrating.xml" />
- <rule ref="rulesets/java/unnecessary.xml">
- <exclude name="UselessParentheses" />
+ <rule ref="category/java/bestpractices.xml">
+ <!-- TODO: can be Handle -->
+ <exclude name="ForLoopCanBeForeach" />
+ <exclude name="UseCollectionIsEmpty" />
+ <exclude name="UnusedLocalVariable" />
+ <exclude name="ForLoopVariableCount" />
+ <exclude name="DoubleBraceInitialization" />
+ <exclude name="AbstractClassWithoutAbstractMethod" />
+ <exclude name="UseTryWithResources" />
+ <exclude name="GuardLogStatement" /> <!-- TODO: guard only debug log level-->
+ <exclude name="UnusedAssignment" />
+ <!-- Nothing -->
+ <exclude name="AvoidReassigningParameters" />
+ <exclude name="MissingOverride" />
+ <exclude name="AvoidPrintStackTrace" />
+ <exclude name="SystemPrintln" />
+ <exclude name="UseVarargs" />
+ <exclude name="LiteralsFirstInComparisons" />
+ <exclude name="JUnitAssertionsShouldIncludeMessage" />
+ <exclude name="UseAssertEqualsInsteadOfAssertTrue" />
+ <exclude name="AvoidUsingHardCodedIP" />
+ <exclude name="AccessorMethodGeneration" />
+ <exclude name="PositionLiteralsFirstInCaseInsensitiveComparisons" />
+ <exclude name="LooseCoupling" />
+ <exclude name="SwitchStmtsShouldHaveDefault" />
+ <exclude name="AvoidReassigningLoopVariables" />
+ <exclude name="JUnitTestContainsTooManyAsserts" />
+ <exclude name="JUnitTestsShouldIncludeAssert" />
+ <exclude name="UseAssertSameInsteadOfAssertTrue" />
+ <exclude name="UseAssertNullInsteadOfAssertTrue" />
+ <exclude name="UseAssertTrueInsteadOfAssertEquals" />
+ <exclude name="MethodReturnsInternalArray" />
+ <exclude name="PreserveStackTrace" />
+ <exclude name="OneDeclarationPerLine" />
+ <exclude name="ArrayIsStoredDirectly" />
+ <exclude name="AccessorClassGeneration" />
+ <exclude name="ConstantsInInterface" />
</rule>
+ <rule ref="category/java/multithreading.xml">
+ <!-- TODO: can be Handle -->
+ <exclude name="DontCallThreadRun" />
+ <exclude name="DoubleCheckedLocking" />
+ <exclude name="AvoidSynchronizedAtMethodLevel" />
+ <exclude name="UseConcurrentHashMap" />
+ <exclude name="AvoidUsingVolatile" />
+ <!-- Nothing -->
+ <exclude name="DoNotUseThreads" />
+ <exclude name="UseNotifyAllInsteadOfNotify" />
+ <exclude name="NonThreadSafeSingleton" />
+</rule>
</ruleset>
diff --git a/pom.xml b/pom.xml
index f764ac3..11a6950 100644
--- a/pom.xml
+++ b/pom.xml
@@ -160,7 +160,7 @@
<local.lib.dir>${project.basedir}/../lib/local</local.lib.dir>
<log4j.version>1.2.17</log4j.version>
<maven.exec.plugin.version>1.6.0</maven.exec.plugin.version>
- <maven.pmd.plugin.version>3.7</maven.pmd.plugin.version>
+ <maven.pmd.plugin.version>3.14.0</maven.pmd.plugin.version>
<metrics.core.version>3.0.2</metrics.core.version>
<mockito.version>3.0.0</mockito.version>
<mockito.all.version>1.10.19</mockito.all.version>
diff --git a/ranger-examples/dev-support/ranger-pmd-ruleset.xml b/ranger-examples/dev-support/ranger-pmd-ruleset.xml
index 96f566a..9e5ed7a 100644
--- a/ranger-examples/dev-support/ranger-pmd-ruleset.xml
+++ b/ranger-examples/dev-support/ranger-pmd-ruleset.xml
@@ -24,36 +24,98 @@
Apache Ranger - PMD rule set
</description>
- <rule ref="rulesets/java/basic.xml">
- <exclude name="AvoidBranchingStatementAsLastInLoop" />
- <exclude name="AvoidThreadGroup" />
- <exclude name="AvoidUsingHardCodedIP" />
- <exclude name="ClassCastExceptionWithToArray" />
- <exclude name="CollapsibleIfStatements" />
- <exclude name="DoubleCheckedLocking" />
- <exclude name="ExtendsObject" />
- <exclude name="OverrideBothEqualsAndHashcode" />
- </rule>
- <rule ref="rulesets/java/unusedcode.xml">
+ <rule ref="category/java/bestpractices.xml">
+ <!-- TODO: can be Handle -->
+ <exclude name="ForLoopCanBeForeach" />
+ <exclude name="UseCollectionIsEmpty" />
<exclude name="UnusedLocalVariable" />
<exclude name="UnusedPrivateField" />
- <exclude name="UnusedPrivateMethod" />
- </rule>
- <rule ref="rulesets/java/imports.xml" />
- <rule ref="rulesets/java/braces.xml">
- <exclude name="ForLoopsMustUseBraces" />
- <exclude name="IfElseStmtsMustUseBraces" />
- <exclude name="IfStmtsMustUseBraces" />
- </rule>
- <rule ref="rulesets/java/empty.xml">
- <exclude name="EmptyCatchBlock" />
- <exclude name="EmptyIfStmt" />
- <exclude name="EmptyStatementNotInLoop" />
- <exclude name="EmptyWhileStmt" />
+ <exclude name="WhileLoopWithLiteralBoolean" />
+ <exclude name="UnusedFormalParameter" />
+ <exclude name="ForLoopVariableCount" />
+ <exclude name="DoubleBraceInitialization" />
+ <exclude name="AbstractClassWithoutAbstractMethod" />
+ <exclude name="UseTryWithResources" />
+ <exclude name="GuardLogStatement" /> <!-- TODO: guard only debug log level-->
+ <!-- Nothing -->
+ <exclude name="AvoidReassigningParameters" />
+ <exclude name="MissingOverride" />
+ <exclude name="AvoidPrintStackTrace" />
+ <exclude name="SystemPrintln" />
+ <exclude name="UseVarargs" />
+ <exclude name="PositionLiteralsFirstInComparisons" />
+ <exclude name="JUnitAssertionsShouldIncludeMessage" />
+ <exclude name="UseAssertEqualsInsteadOfAssertTrue" />
+ <exclude name="AvoidUsingHardCodedIP" />
+ <exclude name="AccessorMethodGeneration" />
+ <exclude name="PositionLiteralsFirstInCaseInsensitiveComparisons" />
+ <exclude name="LooseCoupling" />
+ <exclude name="SwitchStmtsShouldHaveDefault" />
+ <exclude name="AvoidReassigningLoopVariables" />
+ <exclude name="JUnitTestContainsTooManyAsserts" />
+ <exclude name="JUnitTestsShouldIncludeAssert" />
+ <exclude name="UseAssertSameInsteadOfAssertTrue" />
+ <exclude name="UseAssertNullInsteadOfAssertTrue" />
+ <exclude name="UseAssertTrueInsteadOfAssertEquals" />
+ <exclude name="MethodReturnsInternalArray" />
+ <exclude name="PreserveStackTrace" />
+ <exclude name="OneDeclarationPerLine" />
+ <exclude name="ArrayIsStoredDirectly" />
+ <exclude name="AccessorClassGeneration" />
+ <exclude name="ConstantsInInterface" />
</rule>
- <rule ref="rulesets/java/migrating.xml" />
- <rule ref="rulesets/java/unnecessary.xml">
+ <rule ref="category/java/codestyle.xml">
+ <!-- TODO: can be Handle -->
+ <exclude name="UnnecessaryLocalBeforeReturn" />
+ <exclude name="UnnecessaryModifier" />
+ <exclude name="UnnecessaryConstructor" />
+ <exclude name="UnnecessaryFullyQualifiedName" />
+ <exclude name="UnnecessaryAnnotationValueElement" />
+ <exclude name="LocalVariableNamingConventions" />
+ <exclude name="AvoidDollarSigns" />
+ <exclude name="ClassNamingConventions" />
+ <!-- Nothing -->
+ <exclude name="LocalVariableCouldBeFinal" />
+ <exclude name="MethodArgumentCouldBeFinal" />
+ <exclude name="ShortVariable" />
+ <exclude name="LongVariable" />
+ <exclude name="IdenticalCatchBranches" />
+ <exclude name="ControlStatementBraces" />
<exclude name="UselessParentheses" />
+ <exclude name="FieldNamingConventions" />
+ <exclude name="ConfusingTernary" />
+ <exclude name="OnlyOneReturn" />
+ <exclude name="AtLeastOneConstructor" />
+ <exclude name="PrematureDeclaration" />
+ <exclude name="CallSuperInConstructor" />
+ <exclude name="DefaultPackage" />
+ <exclude name="CommentDefaultAccessModifier" />
+ <exclude name="UseDiamondOperator" />
+ <exclude name="FieldDeclarationsShouldBeAtStartOfClass" />
+ <exclude name="BooleanGetMethodName" />
+ <exclude name="EmptyMethodInAbstractClassShouldBeAbstract" />
+ <exclude name="UseUnderscoresInNumericLiterals" />
+ <exclude name="MethodNamingConventions" />
+ <exclude name="UseShortArrayInitializer" />
+ <exclude name="LinguisticNaming" />
+ <exclude name="ShortClassName" />
+ <exclude name="FormalParameterNamingConventions" />
+ <exclude name="ShortMethodName" />
+ <exclude name="PackageCase" />
+ <exclude name="GenericsNaming" />
+ <exclude name="TooManyStaticImports" />
+ </rule>
+ <rule ref="category/java/multithreading.xml">
+ <!-- TODO: can be Handle -->
+ <exclude name="DontCallThreadRun" />
+ <exclude name="DoubleCheckedLocking" />
+ <exclude name="AvoidSynchronizedAtMethodLevel" />
+ <exclude name="UseConcurrentHashMap" />
+ <exclude name="AvoidUsingVolatile" />
+ <!-- Nothing -->
+ <exclude name="DoNotUseThreads" />
+ <exclude name="UseNotifyAllInsteadOfNotify" />
+ <exclude name="NonThreadSafeSingleton" />
</rule>
</ruleset>
diff --git a/security-admin/pom.xml b/security-admin/pom.xml
index 86e46b9..cd87e6c 100644
--- a/security-admin/pom.xml
+++ b/security-admin/pom.xml
@@ -772,7 +772,7 @@
</execution>
</executions>
</plugin>
- <plugin>
+ <!--<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.6</version>
@@ -811,7 +811,7 @@
</goals>
<configuration>
<workingDirectory>${project.build.directory}/jsmain</workingDirectory>
- <arguments>run r.js -- -o ../${project.build.finalName}/minify.build.js</arguments>
+ <arguments>run r.js -- -o ../${project.build.finalName}/minify.build.js</arguments>
</configuration>
</execution>
<execution>
@@ -854,7 +854,7 @@
</configuration>
</execution>
</executions>
- </plugin>
+ </plugin>-->
</plugins>
<resources>
<resource>