[GitHub] xtinec commented on issue #6565: [Design Proposal] Improve SQL Lab Editor Resizer

[GitBox <gi...@apache.org>]

xtinec commented on issue #6565: [Design Proposal] Improve SQL Lab Editor Resizer
URL: https://github.com/apache/incubator-superset/issues/6565#issuecomment-451316967
 
 
   I like @dorq 's proposal. The color difference between the light and dark grey should serve as a natural divide between code and the button area (i.e. code in the light grey area only). When the scorbar comes up, it would only scroll the code area.
    
   I'm not sure where we want to left-align the 'Run Query' button. It looks a bit odd somehow to me to have it aligned "into the gutter" (now that the button area is the same grey, the left end of it looks like an extension of the gutter to me). 
   
   I was thinking perhaps we could align it to the right side of the gutter. As @thinmatt pointed out, the gutter of the ace editor (code area) resizes based on the digits of the line number so in order to align the buttons to the right side of the gutter, we would need to reposition the buttons as the code area grows, which is silly. One possible way around it is to push all the buttons to the right. Perhaps? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org