You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacopo Cappellato (JIRA)" <ji...@apache.org> on 2007/12/04 09:34:43 UTC
[jira] Created: (OFBIZ-1487) Create a service to clone an existing
accounting transaction and its entries (AcctgTrans and AcctgTransEntry),
with an optional parameter to revert the original transaction
Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-1487
URL: https://issues.apache.org/jira/browse/OFBIZ-1487
Project: OFBiz
Issue Type: Sub-task
Components: accounting
Affects Versions: SVN trunk
Reporter: Jacopo Cappellato
Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
Proposed service name: "copyAcctgTransAndEntries"
IN parameters: fromAcctgTransId (mandatory), revert (optional)
OUT parameters: acctgTransId
The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
transactionDate: do not set, so that it will be automatically set to now
isPosted: set to N
postedDate: do not set
scheduledPostedDate: do not set
createdByUserLogin: do not set
lastModifiedByUserLogin: do not set
and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
reconcileStatusId: do not set
For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1487) Create a service to clone an existing
accounting transaction and its entries (AcctgTrans and AcctgTransEntry),
with an optional parameter to revert the original transaction
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pranay Pandey updated OFBIZ-1487:
---------------------------------
Attachment: JiraIssue@1487.patch
I have done changes as per Jacopo's comment for the patch attached earlier :
Follwing changes done :
1. Used "set-service-fields" tag and removed set tags which are not required after doing this.
2. Did controller entry for service which was missing in last patch.
--
Pranay
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1487
> URL: https://issues.apache.org/jira/browse/OFBIZ-1487
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Assignee: Ashish Vijaywargiya
> Attachments: JiraIssue@1487.patch, JiraIssue@1487.patch
>
>
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
> Proposed service name: "copyAcctgTransAndEntries"
> IN parameters: fromAcctgTransId (mandatory), revert (optional)
> OUT parameters: acctgTransId
> The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
> transactionDate: do not set, so that it will be automatically set to now
> isPosted: set to N
> postedDate: do not set
> scheduledPostedDate: do not set
> createdByUserLogin: do not set
> lastModifiedByUserLogin: do not set
> and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
> reconcileStatusId: do not set
> For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
> Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1487) Create a service to clone an existing
accounting transaction and its entries (AcctgTrans and AcctgTransEntry),
with an optional parameter to revert the original transaction
Posted by "SACHIN CHOURASIYA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
SACHIN CHOURASIYA updated OFBIZ-1487:
-------------------------------------
Attachment: JiraIssue@1487.patch
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1487
> URL: https://issues.apache.org/jira/browse/OFBIZ-1487
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Attachments: JiraIssue@1487.patch
>
>
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
> Proposed service name: "copyAcctgTransAndEntries"
> IN parameters: fromAcctgTransId (mandatory), revert (optional)
> OUT parameters: acctgTransId
> The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
> transactionDate: do not set, so that it will be automatically set to now
> isPosted: set to N
> postedDate: do not set
> scheduledPostedDate: do not set
> createdByUserLogin: do not set
> lastModifiedByUserLogin: do not set
> and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
> reconcileStatusId: do not set
> For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
> Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1487) Create a service to clone an existing
accounting transaction and its entries (AcctgTrans and AcctgTransEntry),
with an optional parameter to revert the original transaction
Posted by "SACHIN CHOURASIYA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
SACHIN CHOURASIYA updated OFBIZ-1487:
-------------------------------------
Attachment: (was: jiraIssue@#1473.patch)
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1487
> URL: https://issues.apache.org/jira/browse/OFBIZ-1487
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
>
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
> Proposed service name: "copyAcctgTransAndEntries"
> IN parameters: fromAcctgTransId (mandatory), revert (optional)
> OUT parameters: acctgTransId
> The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
> transactionDate: do not set, so that it will be automatically set to now
> isPosted: set to N
> postedDate: do not set
> scheduledPostedDate: do not set
> createdByUserLogin: do not set
> lastModifiedByUserLogin: do not set
> and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
> reconcileStatusId: do not set
> For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
> Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1487) Create a service to clone an
existing accounting transaction and its entries (AcctgTrans and
AcctgTransEntry), with an optional parameter to revert the original
transaction
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552190 ]
Jacopo Cappellato commented on OFBIZ-1487:
------------------------------------------
To better clarify my last comment: you can use the cloned map (with the adjusted values, as suggested in the above comment) to automatically populate the input map of the service using the "set-service-fields" operation.
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1487
> URL: https://issues.apache.org/jira/browse/OFBIZ-1487
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Attachments: JiraIssue@1487.patch
>
>
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
> Proposed service name: "copyAcctgTransAndEntries"
> IN parameters: fromAcctgTransId (mandatory), revert (optional)
> OUT parameters: acctgTransId
> The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
> transactionDate: do not set, so that it will be automatically set to now
> isPosted: set to N
> postedDate: do not set
> scheduledPostedDate: do not set
> createdByUserLogin: do not set
> lastModifiedByUserLogin: do not set
> and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
> reconcileStatusId: do not set
> For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
> Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1487) Create a service to clone an existing
accounting transaction and its entries (AcctgTrans and AcctgTransEntry),
with an optional parameter to revert the original transaction
Posted by "SACHIN CHOURASIYA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
SACHIN CHOURASIYA updated OFBIZ-1487:
-------------------------------------
Attachment: jiraIssue@#1473.patch
We (Sachin Chourasiya & Rishi) are submitting here our work for creating a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1487
> URL: https://issues.apache.org/jira/browse/OFBIZ-1487
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Attachments: jiraIssue@#1473.patch
>
>
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
> Proposed service name: "copyAcctgTransAndEntries"
> IN parameters: fromAcctgTransId (mandatory), revert (optional)
> OUT parameters: acctgTransId
> The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
> transactionDate: do not set, so that it will be automatically set to now
> isPosted: set to N
> postedDate: do not set
> scheduledPostedDate: do not set
> createdByUserLogin: do not set
> lastModifiedByUserLogin: do not set
> and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
> reconcileStatusId: do not set
> For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
> Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1487) Create a service to clone an existing
accounting transaction and its entries (AcctgTrans and AcctgTransEntry),
with an optional parameter to revert the original transaction
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-1487.
--------------------------------------
Resolution: Fixed
Thanks Sachin and Rishi Solanki for your patch.
Special thanks to Pranay Pandey for working on Jacopo's comments.
Changes are in rev # 606519
--
Ashish Vijaywargiya
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1487
> URL: https://issues.apache.org/jira/browse/OFBIZ-1487
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Assignee: Ashish Vijaywargiya
> Attachments: JiraIssue@1487.patch, JiraIssue@1487.patch
>
>
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
> Proposed service name: "copyAcctgTransAndEntries"
> IN parameters: fromAcctgTransId (mandatory), revert (optional)
> OUT parameters: acctgTransId
> The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
> transactionDate: do not set, so that it will be automatically set to now
> isPosted: set to N
> postedDate: do not set
> scheduledPostedDate: do not set
> createdByUserLogin: do not set
> lastModifiedByUserLogin: do not set
> and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
> reconcileStatusId: do not set
> For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
> Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1487) Create a service to clone an
existing accounting transaction and its entries (AcctgTrans and
AcctgTransEntry), with an optional parameter to revert the original
transaction
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552188 ]
Jacopo Cappellato commented on OFBIZ-1487:
------------------------------------------
Looks good,
however we can probably suppress most of the "set" operations because the "clone-value" operation should already duplicate all the fields values; for this reason we will just have to override some of the fields (debitCreditFlag, isPosted, transactionDate...) and clear the acctgTransId one (use the "clear-field" operation for this).
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1487
> URL: https://issues.apache.org/jira/browse/OFBIZ-1487
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Attachments: JiraIssue@1487.patch
>
>
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
> Proposed service name: "copyAcctgTransAndEntries"
> IN parameters: fromAcctgTransId (mandatory), revert (optional)
> OUT parameters: acctgTransId
> The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
> transactionDate: do not set, so that it will be automatically set to now
> isPosted: set to N
> postedDate: do not set
> scheduledPostedDate: do not set
> createdByUserLogin: do not set
> lastModifiedByUserLogin: do not set
> and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
> reconcileStatusId: do not set
> For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
> Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1487) Create a service to clone an existing
accounting transaction and its entries (AcctgTrans and AcctgTransEntry),
with an optional parameter to revert the original transaction
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-1487:
------------------------------------------
Assignee: Ashish Vijaywargiya
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1487
> URL: https://issues.apache.org/jira/browse/OFBIZ-1487
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Assignee: Ashish Vijaywargiya
> Attachments: JiraIssue@1487.patch
>
>
> Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction.
> Proposed service name: "copyAcctgTransAndEntries"
> IN parameters: fromAcctgTransId (mandatory), revert (optional)
> OUT parameters: acctgTransId
> The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields:
> transactionDate: do not set, so that it will be automatically set to now
> isPosted: set to N
> postedDate: do not set
> scheduledPostedDate: do not set
> createdByUserLogin: do not set
> lastModifiedByUserLogin: do not set
> and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields:
> reconcileStatusId: do not set
> For each entry, if the parameters.revert field is set to "Y", flip the debitCreditFlag from C to D and vice versa.
> Add two new links to the "Edit Accounting Transaction" screen: "duplicate accounting transaction" and "revert accounting transaction" that both call the above service (the latter calls the service with revert=Y).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.