You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/05/07 08:32:01 UTC
[jira] [Commented] (LENS-256) lens-cli should not use single
parameter for two values
[ https://issues.apache.org/jira/browse/LENS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532099#comment-14532099 ]
Hudson commented on LENS-256:
-----------------------------
SUCCESS: Integrated in Lens-Commit #759 (See [https://builds.apache.org/job/Lens-Commit/759/])
LENS-256 : lens-cli should not use single parameter for two values (Rajat Khandelwal via amareshwari) (amareshwari: rev 10917c25e4bd1ddaceef242836a25bb555e3e95e)
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java
* lens-cli/src/test/resources/cli-intro.apt
* src/site/apt/user/cli.apt
* lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java
* lens-cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/UserDocumentation.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java
* lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
* lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java
* tools/scripts/generate-site-public.sh
* lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java
* lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java
* lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java
* lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java
* lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java
> lens-cli should not use single parameter for two values
> -------------------------------------------------------
>
> Key: LENS-256
> URL: https://issues.apache.org/jira/browse/LENS-256
> Project: Apache Lens
> Issue Type: Improvement
> Components: client
> Affects Versions: 2.2
> Reporter: Amareshwari Sriramadasu
> Assignee: Rajat Khandelwal
> Fix For: 2.2
>
> Attachments: rb33392.patch
>
>
> We have code like the following in many places in cli :
> {noformat}
> @CliCommand(value = "update storage", help = "update storage")
> public String updateStorage(
> @CliOption(key = { "", "storage" }, mandatory = true, help = "<storage-name> <path to storage-spec>") String specPair) {
> Iterable<String> parts = Splitter.on(' ').trimResults().omitEmptyStrings().split(specPair);
> {noformat}
> It should take separate parameters for each value than doing split on space
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)