You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benedict (JIRA)" <ji...@apache.org> on 2014/05/01 23:10:18 UTC
[jira] [Commented] (CASSANDRA-6861) Optimise our Netty 4
integration
[ https://issues.apache.org/jira/browse/CASSANDRA-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987002#comment-13987002 ]
Benedict commented on CASSANDRA-6861:
-------------------------------------
It looks like we're still allocating a lot of unpooled buffers, even though they are now (mostly) being released. We'd like to allocate them from a pool if possible.
It seems CBUtil.readValue() can also still allocate unpooled buffers that won't have release called on them (though likely the code path isn't being exercised right now) - since this one just returns an NIO buffer, it's probably easiest to simply allocate a ByteBuffer and read the bytes into it.
> Optimise our Netty 4 integration
> --------------------------------
>
> Key: CASSANDRA-6861
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6861
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: T Jake Luciani
> Priority: Minor
> Labels: performance
> Fix For: 2.1 beta2
>
>
> Now we've upgraded to Netty 4, we're generating a lot of garbage that could be avoided, so we should probably stop that. Should be reasonably easy to hook into Netty's pooled buffers, returning them to the pool once a given message is completed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)