You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "PG1204 (via GitHub)" <gi...@apache.org> on 2026/09/10 04:36:24 UTC
[PR] fix(workflow-operator): validate the spam operator's result attributes like its siblings [texera]
PG1204 opened a new pull request, #8483:
URL: https://github.com/apache/texera/pull/8483
### What changes were proposed in this PR?
`HuggingFaceSpamSMSDetectionOpDesc.getOutputSchemas` was the only one of the four legacy Hugging Face operators that neither validated its result-attribute names nor keyed the input schema by port id.
`getOutputSchemas` is called as the user configures an operator, so it needs an answer for "not filled in yet". `HuggingFaceSentimentAnalysisOpDesc` and `HuggingFaceIrisLogisticRegressionOpDesc` answer by returning `null`; this operator instead passed the unset name straight into `Schema.add`. It now returns `null` when either `resultAttributeSpam` or `resultAttributeProbability` is null or blank, matching its siblings.
The input schema is also now read as `inputSchemas(operatorInfo.inputPorts.head.id)` rather than `inputSchemas.values.head`, consistent with the sibling operators. With a single input port these are equivalent, so this is a consistency change rather than a behavioral fix.
Unifying the error contract across all four legacy operators, two return `null`, one throws, this one did neither — is a broader question and is not attempted here.
### Any related issues?
Closes #8482
### How was this PR tested?
347 tests pass across the `huggingFace` and operator-metadata suites, and `scalafmtCheck` is clean for main and test sources. Two tests were added to `HuggingFaceSpamSMSDetectionOpDescSpec` covering an unset and a blank name for both result attributes. Reverting the operator change and re-running makes exactly those two tests fail, confirming they exercise the fix; the existing happy-path test already keys the input schema by the declared input port, so it covers the lookup change.
### Was this PR authored or co-authored using generative AI tooling?
Yes, this PR was co-authored with Claude in compliance with ASF policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): validate the spam operator's result attributes like its siblings [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8483:
URL: https://github.com/apache/texera/pull/8483#issuecomment-5613312376
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. A `release/*` label nominates a backport target; the branch's release manager approving this PR is what sends the fix there. The required **Backport Approvals** check stays red until every label below is approved, so each manager either approves or removes their own label — which is why the labels left on a merged PR are exactly the branches it reached.
| Release branch | Analysis |
| --- | --- |
| ✅ `release/v1.3` | Change detected on this branch — label added; this fix is queued to backport here. @mengw15 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested. |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. @xuang7 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/34437828996)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): validate the spam operator's result attributes like its siblings [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8483:
URL: https://github.com/apache/texera/pull/8483#issuecomment-5613522379
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.92%. Comparing base ([`ded7ba1`](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f28c057`](https://app.codecov.io/gh/apache/texera/commit/f28c05792532e5ba38de2461cc9286e187205ff9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8483 +/- ##
=========================================
Coverage 93.92% 93.92%
Complexity 4826 4826
=========================================
Files 1209 1209
Lines 49815 49796 -19
Branches 6088 6082 -6
=========================================
- Hits 46787 46773 -14
Misses 1536 1536
+ Partials 1492 1487 -5
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (+0.81%)` | :arrow_up: | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [ded7ba1](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.91% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [ded7ba1](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.05% <ø> (ø)` | | Carriedforward from [ded7ba1](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.00% <ø> (-0.13%)` | :arrow_down: | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.65% <ø> (ø)` | | Carriedforward from [ded7ba1](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.71% <ø> (ø)` | | Carriedforward from [ded7ba1](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [ded7ba1](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.47% <ø> (ø)` | | Carriedforward from [ded7ba1](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [ded7ba1](https://app.codecov.io/gh/apache/texera/commit/ded7ba1b49d0dc6644bc34b765b727607ad9d654?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8483?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): validate the spam operator's result attributes like its siblings [texera]
Posted by "PG1204 (via GitHub)" <gi...@apache.org>.
PG1204 commented on PR #8483:
URL: https://github.com/apache/texera/pull/8483#issuecomment-5613267008
/request-review @Ma77Ball
this is a small fix unrelated to HuggingFaceInferenceOpDesc, this fix is for the HuggingFaceSpamSMSDetectionOpDesc op.
sentiment analysis and iris already return null from getOutputSchemas when a result attribute isn't set yet, and key the input schema by port id. This one did neither.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): validate the spam operator's result attributes like its siblings [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8483:
URL: https://github.com/apache/texera/pull/8483#issuecomment-5613312979
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@kz930`
You can notify them by mentioning `@kz930` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): validate the spam operator's result attributes like its siblings [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8483:
URL: https://github.com/apache/texera/pull/8483#issuecomment-5613526540
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 7 worse · ⚪ 8 noise (<±5%) · 0 without baseline
> Compared against main `ded7ba1` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/34438425500)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 640 | 0.39 | 15,210/22,749/22,749 us | 🔴 +16.0% / 🔴 +40.1% |
| 🔴 | bs=100 sw=10 sl=64 | 1,301 | 0.794 | 73,832/110,776/110,776 us | 🔴 +10.7% / 🟢 +32.4% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,519 | 0.927 | 658,956/697,936/697,936 us | ⚪ within ±5% / 🟢 +50.4% |
<details><summary>Baseline details</summary>
Latest main `ded7ba1` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 640 tuples/sec | 740 tuples/sec | 754.83 tuples/sec | -13.5% | -15.2% |
| bs=10 sw=10 sl=64 | MB/s | 0.39 MB/s | 0.452 MB/s | 0.461 MB/s | -13.7% | -15.3% |
| bs=10 sw=10 sl=64 | p50 | 15,210 us | 13,116 us | 12,950 us | +16.0% | +17.5% |
| bs=10 sw=10 sl=64 | p95 | 22,749 us | 20,022 us | 16,243 us | +13.6% | +40.1% |
| bs=10 sw=10 sl=64 | p99 | 22,749 us | 20,022 us | 19,574 us | +13.6% | +16.2% |
| bs=100 sw=10 sl=64 | throughput | 1,301 tuples/sec | 1,299 tuples/sec | 982.46 tuples/sec | +0.2% | +32.4% |
| bs=100 sw=10 sl=64 | MB/s | 0.794 MB/s | 0.793 MB/s | 0.6 MB/s | +0.1% | +32.4% |
| bs=100 sw=10 sl=64 | p50 | 73,832 us | 76,517 us | 101,575 us | -3.5% | -27.3% |
| bs=100 sw=10 sl=64 | p95 | 110,776 us | 100,086 us | 108,655 us | +10.7% | +2.0% |
| bs=100 sw=10 sl=64 | p99 | 110,776 us | 100,086 us | 121,794 us | +10.7% | -9.0% |
| bs=1000 sw=10 sl=64 | throughput | 1,519 tuples/sec | 1,514 tuples/sec | 1,010 tuples/sec | +0.3% | +50.4% |
| bs=1000 sw=10 sl=64 | MB/s | 0.927 MB/s | 0.924 MB/s | 0.616 MB/s | +0.3% | +50.4% |
| bs=1000 sw=10 sl=64 | p50 | 658,956 us | 655,367 us | 998,032 us | +0.5% | -34.0% |
| bs=1000 sw=10 sl=64 | p95 | 697,936 us | 715,441 us | 1,039,429 us | -2.4% | -32.9% |
| bs=1000 sw=10 sl=64 | p99 | 697,936 us | 715,441 us | 1,068,120 us | -2.4% | -34.7% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,312.74,200,128000,640,0.390,15209.79,22748.88,22748.88
1,100,10,64,20,1536.85,2000,1280000,1301,0.794,73831.64,110776.04,110776.04
2,1000,10,64,20,13163.32,20000,12800000,1519,0.927,658956.42,697936.46,697936.46
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): validate the spam operator's result attributes like its siblings [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #8483:
URL: https://github.com/apache/texera/pull/8483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org