You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Robert Burke (JIRA)" <ji...@apache.org> on 2018/07/02 23:50:00 UTC

[jira] [Commented] (BEAM-3545) Fn API metrics in Go SDK harness

    [ https://issues.apache.org/jira/browse/BEAM-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530591#comment-16530591 ] 

Robert Burke commented on BEAM-3545:
------------------------------------

I have a suspicion that I have not implemented gauges correctly. I could not find a semantics doc. I'm not certain of this, but I suspect we should be propagating the maximum value + associated timestamp, rather than the "last seen" value + associated timestamp which is what it is now. It shouldn't affect the user side at all though.

I have some performance improvements for the metrics in the works, which should be sufficient to close this, I just need to write some benchmarks to discourage regression.

 

> Fn API metrics in Go SDK harness
> --------------------------------
>
>                 Key: BEAM-3545
>                 URL: https://issues.apache.org/jira/browse/BEAM-3545
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Kenneth Knowles
>            Assignee: Robert Burke
>            Priority: Major
>              Labels: portability
>          Time Spent: 9.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)