You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/10/01 08:30:55 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43192: [SPARK-45390][PYTHON] Remove `distutils` usage

dongjoon-hyun commented on code in PR #43192:
URL: https://github.com/apache/spark/pull/43192#discussion_r1342099075


##########
LICENSE:
##########
@@ -221,6 +221,7 @@ connector/spark-ganglia-lgpl/src/main/java/com/codahale/metrics/ganglia/GangliaR
 Python Software Foundation License
 ----------------------------------
 
+python/pyspark/loose_version.py
 python/docs/source/_static/copybutton.js

Review Comment:
   Yes and no~
   
   Yes, we had `copybutton.js` file.
   ```
   spark-3.5.0-bin-hadoop3:$ find . -name copybutton.js
   ./python/docs/source/_static/copybutton.js
   ```
   
   But, still no. We didn't have no PSF entry in `LICENSE-binary` which is a part of Apache Spark binary distribution. So, I added in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org